Mutable Group Permissions #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameronvoell
force-pushed
the
cv/policy-set-mutable
branch
from
d5ff41a to
823187f
Compare
cameronvoell
force-pushed
the
cv/policy-set-mutable
branch
from
823187f to
077e544
Compare
cameronvoell
changed the title
30 tasks
neekolas
reviewed
May 2, 2024
|
|
||
| // Wrapper around a list of repeated EVM Account Addresses | ||
| message AccountAddresses { | ||
| repeated string account_addresses = 1; |
There was a problem hiding this comment.
Given how close we are to the inbox_id work merging in, I have a hacky suggestion for you. Can we just call the field inbox_ids and rename the message Inboxes?
You can still put wallet addresses into the field for now (they're all strings). But it'll save me from having to go back and change this proto next week.
neekolas
approved these changes
May 2, 2024
1 task
richardhuaaa
approved these changes
May 10, 2024
|
🎉 This PR is included in version 3.57.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Tracking Issue for details: xmtp/libxmtp#664