Added new Permissions Extension (#724) #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added new Permissions Extension * fix bindings * update TODO for follow up PR * Update xmtp_mls/src/groups/group_mutable_metadata.rs clean up admin list error checking Co-authored-by: 37ng <[email protected]> * Revert "Update xmtp_mls/src/groups/group_mutable_metadata.rs " This reverts commit 1b0cc38. * fixed concise error checking * Point gen_protos.sh back to main branch * lint fix after merge --------- Co-authored-by: cameronvoell <[email protected]> Co-authored-by: 37ng <[email protected]>
Merged
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
I'm going to merge this into the child, since there's so much overlap and churn between the two |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr
maininto this branch, which picks up @cameronvoell's updated permissions PR