WIP: add kwarg to accept new tune points, rather than remap onto the old #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeepCode Report (#916721)DeepCode analyzed this pull request. |
|
I intend to add this dataset as a test as well |
|
@ksunden what's the status of this PR? |
|
@untzag I think we want to rework it a bit, adding the ability to pass an array to map to instead of only being True/False |
ksunden
changed the title
|
Closing as it is firmly outdated by #93 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #60
Here is a tune test taken on the PS table recently
This revealed two main deficiencies:
Our plotting seems to be doing something different than what we thought
I've suspected as much in the past, but never saw it bad enough to be sure
When the colors are particularly far off (as with this where both ends of the curve were well off from the appropriate colors), we may actually want to accept the colors that the procedure fits, rather than remapping onto the original setpoints.
This PR deals with the latter, adding a simple boolean kwarg which defaults to true, but if set to false will avoid remapping
Doing so will lead to changing your curve tuning range, and is not reccommended in most cases, except where you are not confident in what the tuning range should actually be