Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Musical metaphor #93

Merged
merged 19 commits into from
Sep 24, 2020
Merged

Musical metaphor #93

merged 19 commits into from
Sep 24, 2020

Conversation

ksunden
Copy link
Member

@ksunden ksunden commented Aug 20, 2020

No description provided.

@lgtm-com
Copy link

lgtm-com bot commented Aug 20, 2020

This pull request introduces 3 alerts when merging c610187 into bdb5562 - view on LGTM.com

new alerts:

  • 2 for Module imports itself
  • 1 for 'import *' may pollute namespace

@lgtm-com
Copy link

lgtm-com bot commented Aug 20, 2020

This pull request introduces 4 alerts when merging 1e47d5f into bdb5562 - view on LGTM.com

new alerts:

  • 2 for Module imports itself
  • 1 for First parameter of a method is not named 'self'
  • 1 for 'import *' may pollute namespace

@ghost
Copy link

ghost commented Aug 20, 2020

DeepCode's analysis on #c98e00 found:

  • 1 critical issue, ⚠️ 2 warnings, ℹ️ 8 minor issues. 👇

Top issues

Description Example fixes
Use binary mode in open (current mode is w) to avoid encoding-related issues for written file, on Windows or with Python 3. Occurrences: 🔧 Example fixes
Defining only __eq__ but not __ne__ will result in a Python2 error if objects are compared with inequality. Occurrences: 🔧 Example fixes
Missing close for open, add close or use a with block. Occurrences: 🔧 Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@lgtm-com
Copy link

lgtm-com bot commented Aug 21, 2020

This pull request introduces 2 alerts when merging 6c0febb into bdb5562 - view on LGTM.com

new alerts:

  • 1 for Comparison of identical values
  • 1 for 'import *' may pollute namespace

@lgtm-com
Copy link

lgtm-com bot commented Aug 21, 2020

This pull request introduces 3 alerts when merging 45df213 into bdb5562 - view on LGTM.com

new alerts:

  • 1 for Unused import
  • 1 for Comparison of identical values
  • 1 for 'import *' may pollute namespace

@lgtm-com
Copy link

lgtm-com bot commented Aug 21, 2020

This pull request introduces 2 alerts when merging 635507b into bdb5562 - view on LGTM.com

new alerts:

  • 1 for Unused import
  • 1 for 'import *' may pollute namespace

@lgtm-com
Copy link

lgtm-com bot commented Aug 21, 2020

This pull request introduces 2 alerts when merging 8a87992 into bdb5562 - view on LGTM.com

new alerts:

  • 1 for Unused import
  • 1 for 'import *' may pollute namespace

@lgtm-com
Copy link

lgtm-com bot commented Aug 25, 2020

This pull request introduces 3 alerts when merging 7bac7b7 into bdb5562 - view on LGTM.com

new alerts:

  • 1 for Wrong name for an argument in a call
  • 1 for Unused import
  • 1 for Explicit export is not defined

@lgtm-com
Copy link

lgtm-com bot commented Aug 28, 2020

This pull request introduces 2 alerts when merging bac5755 into bdb5562 - view on LGTM.com

new alerts:

  • 1 for Unused import
  • 1 for Explicit export is not defined

@lgtm-com
Copy link

lgtm-com bot commented Aug 28, 2020

This pull request introduces 1 alert when merging 44a0cca into bdb5562 - view on LGTM.com

new alerts:

  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Aug 29, 2020

This pull request introduces 1 alert when merging 2797fd2 into bdb5562 - view on LGTM.com

new alerts:

  • 1 for Unused local variable

@lgtm-com
Copy link

lgtm-com bot commented Aug 29, 2020

This pull request introduces 1 alert when merging 2d17ebf into bdb5562 - view on LGTM.com

new alerts:

  • 1 for Unused local variable

@ksunden ksunden merged commit a08c48c into master Sep 24, 2020
@ksunden ksunden deleted the whatever branch September 24, 2020 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants