Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tune test plotting seems off #69

Closed
ksunden opened this issue Aug 28, 2019 · 1 comment · Fixed by #77
Closed

Tune test plotting seems off #69

ksunden opened this issue Aug 28, 2019 · 1 comment · Fixed by #77
Milestone

Comments

@ksunden
Copy link
Member

ksunden commented Aug 28, 2019

tune_test
Here is a tune test taken on the PS table recently

This revealed two main deficiencies:

  1. Our plotting seems to be doing something different than what we thought
    I've suspected as much in the past, but never saw it bad enough to be sure

  2. When the colors are particularly far off (as with this where both ends of the curve were well off from the appropriate colors), we may actually want to accept the colors that the procedure fits, rather than remapping onto the original setpoints.

PR #68 deals with the latter, this issue is documenting the former

@ksunden
Copy link
Member Author

ksunden commented Aug 28, 2019

Note that the grey line, should be the fits following along the maxima, but it is squished in this view so that its domain does not cover the values it should

ksunden added a commit that referenced this issue Nov 15, 2019
untzag pushed a commit that referenced this issue Nov 19, 2019
* Use old curve setpoints for offsets

Closes #52 Closes #69

* modify curve _before_ plotting
@ksunden ksunden added this to the 0.2.0 milestone Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant