[RNMobile] Upgrade Gradle to 8.2.1 and AGP to 8.1.0
#5989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
50 tasks
12 tasks
fluiddot
reviewed
Jul 25, 2023
fluiddot
force-pushed
the
version-toolkit/gutenberg/rnmobile/0.69.4-upgrade-gradle-to-8.2.1-and-agp-to-8.0.2
branch
from
8fc7397 to
2476fd9
Compare
fluiddot
reviewed
Jul 25, 2023
fluiddot
force-pushed
the
version-toolkit/gutenberg/rnmobile/0.69.4-upgrade-gradle-to-8.2.1-and-agp-to-8.0.2
branch
from
b630fc0 to
aa5ea08
Compare
For some reason, the default behavior of picking automatically a node version after loading the nvm script, it's leading to a failure in consecutive steps after the `install-node-version` step.
fluiddot
force-pushed
the
version-toolkit/gutenberg/rnmobile/0.69.4-upgrade-gradle-to-8.2.1-and-agp-to-8.0.2
branch
from
2b7cffc to
ea7a603
Compare
…image-to-add-JDK-17-support Update Android Docker Image to add JDK 17 support
fluiddot
reviewed
Jul 26, 2023
| @@ -160,8 +160,7 @@ commands: | |||
| parameters: | |||
| android-docker-image: | |||
| type: string | |||
| # Hash points to previous version with node 12. When everything works with node 14 it can be removed | |||
| default: "circleci/android:api-29-node@sha256:71d61d6c21b29948d57120f476a83cc322a280979bce355c5a0ad771293ca380" | |||
| default: "cimg/android:2023.07-node" | |||
There was a problem hiding this comment.
Since we pick the needed node/npm version via nvm (reference), we can use the latest version of CircleCI's Android docker image. Note the tag is different because the previous one was deprecated, more information can be found in Legacy Convenience Image Deprecation.
fluiddot
reviewed
Jul 26, 2023
| @@ -147,7 +147,7 @@ commands: | |||
| echo 'Default NVM_DIR to .nvm in home' | |||
| echo 'export NVM_DIR="$HOME/.nvm"' >> $BASH_ENV | |||
| fi | |||
| echo '[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"' >> $BASH_ENV | |||
| echo '[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh" --no-use' >> $BASH_ENV | |||
There was a problem hiding this comment.
NVM tries to pick the node version automatically upon loading the script. For some reason, when using the new CircleCI's docker image, this leads to a failure related to not finding node 14. As a workaround, this behavior has been disabled using the --no-use argument. This should have no impact on the job, as we explicitly pick the node version here.
This reverts commit e3914fa.
…pgrade-gradle-to-8.2.1-and-agp-to-8.0.2 # Conflicts: # gutenberg
fluiddot
changed the title
8.2.1 and AGP to 8.0.28.2.1 and AGP to 8.1.0
SiobhyB
approved these changes
Jul 28, 2023
oguzkocer
deleted the
version-toolkit/gutenberg/rnmobile/0.69.4-upgrade-gradle-to-8.2.1-and-agp-to-8.0.2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs
8.2.1and AGP to8.1.0WordPress/gutenberg#52872 by @fluiddotDescription
This PR is generated by
version-toolkitto downstream the changes forgutenbergsubmodule.