Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Android Docker Image to add JDK 17 support #5993

Conversation

oguzkocer
Copy link
Contributor

@oguzkocer oguzkocer commented Jul 25, 2023

The only change worth noting between the two Docker images is the JDK update from 11 to 17. That means JDK 11 will no longer be available. However, since this PR is targeting the AGP 8.0.2 update PR, which requires JDK 17, that shouldn't be a problem for this repository.

To test:
Verify that Android publishing CI steps are successful

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@oguzkocer oguzkocer force-pushed the update/android-docker-image-to-add-JDK-17-support branch from deadc2b to 7edce45 Compare July 25, 2023 18:49
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jul 25, 2023

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@oguzkocer oguzkocer force-pushed the update/android-docker-image-to-add-JDK-17-support branch from 7edce45 to 271ab56 Compare July 25, 2023 20:09
@oguzkocer oguzkocer marked this pull request as ready for review July 25, 2023 21:13
@oguzkocer oguzkocer requested review from ParaskP7 and fluiddot July 25, 2023 21:13
Copy link

@ParaskP7 ParaskP7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎊 ! Thanks!

@fluiddot fluiddot merged commit 3e05b15 into version-toolkit/gutenberg/rnmobile/0.69.4-upgrade-gradle-to-8.2.1-and-agp-to-8.0.2 Jul 26, 2023
@fluiddot fluiddot deleted the update/android-docker-image-to-add-JDK-17-support branch July 26, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants