Update JDK version to 17 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for JDK 17 by rebuilding the image. There was no extra action needed for this as I think it's covered by one of the
apt-getpackages. Note that this removes support for JDK 11, but since this Docker image is only used forgutenberg-mobile, we shouldn't need it. I believe our long term plan is to deprecate this image entirely, so I don't think it's worth spending the extra time to support multiple JDK versions.I've updated the Android build tools to
33(current) &34(upcoming) and uninstalled29so that builds won't complain about it being installed in an incorrect location which I think is related to theapt-getpackage installations. I've also updated the cached Gradle version to8.2.1.To Test
I've updated
gutenberg-mobileto use this image in wordpress-mobile/gutenberg-mobile#5993 and verified that the CI is green. Prior to this change, the builds were failing due to the missing JDK 17 in wordpress-mobile/gutenberg-mobile#5989. So, no testing is necessary.