Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Check Correctness" job failure on CI #2908

Merged
merged 6 commits into from
Dec 16, 2020
Merged

Conversation

ceyhun
Copy link
Contributor

@ceyhun ceyhun commented Dec 16, 2020

Fixes Check Correctness failure with Message: package-lock.json has changed. Please run npm install and commit the diff

It seems to be related to node and/or npm version. I bumped the docker node image in CircleCI to 14 and after updated package-lock.json running npm install.

I also added an extra command to print the git diff before failing a job.

To test:

Check if Check Correctness is passing on CircleCI.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@ceyhun ceyhun added the Tooling label Dec 16, 2020
@ceyhun ceyhun requested a review from geriux December 16, 2020 10:44
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Dec 16, 2020

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@ceyhun ceyhun requested review from guarani and removed request for geriux December 16, 2020 14:32
@cameronvoell cameronvoell self-requested a review December 16, 2020 16:33
Copy link
Contributor

@cameronvoell cameronvoell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and good thinking adding the echo "$diff" :shipit:

@ceyhun ceyhun merged commit 1df81f6 into develop Dec 16, 2020
@ceyhun ceyhun deleted the fix/check-correctness-on-ci branch December 16, 2020 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants