Fix "Check Correctness" job failure on CI #2908
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Check Correctness
failure withMessage: package-lock.json has changed. Please run npm install and commit the diff
It seems to be related to node and/or npm version. I bumped the docker node image in CircleCI to 14 and after updated
package-lock.json
runningnpm install
.I also added an extra command to print the git diff before failing a job.
To test:
Check if
Check Correctness
is passing on CircleCI.PR submission checklist: