Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Check Correctness" job failure on CI #2908

Merged
merged 6 commits into from
Dec 16, 2020
Merged

Fix "Check Correctness" job failure on CI #2908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
72d1deb
Bump docker image to node 14
ceyhun Dec 15, 2020
6b93bc0
Update package-lock.json
ceyhun Dec 15, 2020
880b1c1
Update package-lock.json again
ceyhun Dec 15, 2020
b4f54b3
Print git diff before failing job
ceyhun Dec 16, 2020
4d4c1ab
Update package-lock.json again
ceyhun Dec 16, 2020
440370d
Print new lines as well while echoing diff
ceyhun Dec 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ jobs:
type: boolean
default: false
docker:
- image: circleci/node:10
- image: circleci/node:14
steps:
- checkout
- checkout-submodules
Expand Down
1 change: 1 addition & 0 deletions bin/ci-checks-js.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ function checkDiff() {
if [[ $? != 0 ]]; then
pFail
elif [[ $diff ]]; then
echo "$diff"
pFail "package-lock.json has changed. Please run npm install and commit the diff"
else
pOk
Expand Down
Loading