Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add current prettier version to lock file #2885

Closed
wants to merge 1 commit into from
Closed

Add current prettier version to lock file #2885

wants to merge 1 commit into from

Conversation

guarani
Copy link
Contributor

@guarani guarani commented Dec 9, 2020

PRs were failing due to a CircleCI check that ensures that after running npm install, no changes are made to the package-lock.json file.

The prettier package was breaking here since it seems like the last changes to its version were not added to the lock file.

To test:

  1. Check CI output for the check-correctness job

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@guarani
Add prettier version to lock file
8dc5d9f 
PRs were failing due to a CircleCI check that ensures that after running `npm install`, no changes are made to the `package-lock.json` file.

The prettier package was breaking here since it seems like the last changes to its version were not added to the lock file.
@chipsnyder chipsnyder mentioned this pull request Dec 9, 2020
Closed
@guarani
Copy link
Contributor Author

guarani commented Dec 25, 2020

Closing since #2908 addressed this.

@guarani guarani closed this Dec 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@guarani