Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for the Classic Block "null" inside the Unsupported Block editor #2550

Conversation

hypest
Copy link
Contributor

@hypest hypest commented Aug 14, 2020

This PR includes a fix for the Unsupported Block editor to better support the Classic block.

This PR is based on v1.33.1 so to land it as a hotfix onto WPAndroid v15.4. There's an accompanying PR based on v1.32 to land the same fix on WPiOS v15.3 (notice the difference in the WP apps and versions).

Gutenberg PR: WordPress/gutenberg#24569

To test:

Follow the steps outlined in the GB PR above

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@hypest hypest requested a review from etoledom August 14, 2020 11:09
@hypest hypest changed the title Update Gutenberg hash to point to the fix Fix for the Classic Block "null" insisde the Unsupported Block editor Aug 14, 2020
@hypest hypest force-pushed the hotfix/fix-loading-classic-block-in-unsupported-editor branch from cb5dea6 to 63c5a30 Compare August 14, 2020 12:30
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Aug 14, 2020

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@hypest hypest changed the base branch from main to release/1.33.2 August 14, 2020 12:31
@hypest hypest marked this pull request as ready for review August 14, 2020 13:16
@hypest hypest changed the title Fix for the Classic Block "null" insisde the Unsupported Block editor Fix for the Classic Block "null" inside the Unsupported Block editor Aug 14, 2020
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marecar3 marecar3 self-requested a review August 14, 2020 15:21
Copy link
Contributor

@marecar3 marecar3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@cameronvoell cameronvoell merged commit 9cbec1d into release/1.33.2 Aug 14, 2020
@cameronvoell cameronvoell deleted the hotfix/fix-loading-classic-block-in-unsupported-editor branch August 14, 2020 22:05
@cameronvoell cameronvoell restored the hotfix/fix-loading-classic-block-in-unsupported-editor branch August 14, 2020 22:17
@cameronvoell cameronvoell deleted the hotfix/fix-loading-classic-block-in-unsupported-editor branch September 27, 2020 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants