-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for the Classic Block "null" inside the Unsupported Block editor #2550
Merged
cameronvoell
merged 2 commits into
release/1.33.2
from
hotfix/fix-loading-classic-block-in-unsupported-editor
Aug 14, 2020
Merged
Fix for the Classic Block "null" inside the Unsupported Block editor #2550
cameronvoell
merged 2 commits into
release/1.33.2
from
hotfix/fix-loading-classic-block-in-unsupported-editor
Aug 14, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
hypest
changed the title
Update Gutenberg hash to point to the fix
Fix for the Classic Block "null" insisde the Unsupported Block editor
Aug 14, 2020
3 tasks
hypest
force-pushed
the
hotfix/fix-loading-classic-block-in-unsupported-editor
branch
from
August 14, 2020 12:30
cb5dea6
to
63c5a30
Compare
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
6 tasks
2 tasks
hypest
changed the title
Fix for the Classic Block "null" insisde the Unsupported Block editor
Fix for the Classic Block "null" inside the Unsupported Block editor
Aug 14, 2020
etoledom
approved these changes
Aug 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved via WordPress/gutenberg#24569 (review)
marecar3
approved these changes
Aug 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉
cameronvoell
deleted the
hotfix/fix-loading-classic-block-in-unsupported-editor
branch
August 14, 2020 22:05
cameronvoell
restored the
hotfix/fix-loading-classic-block-in-unsupported-editor
branch
August 14, 2020 22:17
This was referenced Aug 14, 2020
cameronvoell
deleted the
hotfix/fix-loading-classic-block-in-unsupported-editor
branch
September 27, 2020 22:56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a fix for the Unsupported Block editor to better support the Classic block.
This PR is based on v1.33.1 so to land it as a hotfix onto WPAndroid v15.4. There's an accompanying PR based on v1.32 to land the same fix on WPiOS v15.3 (notice the difference in the WP apps and versions).
Gutenberg PR: WordPress/gutenberg#24569
To test:
Follow the steps outlined in the GB PR above
PR submission checklist: