Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Classic Block in the Unsupported Block editor #12685

Conversation

cameronvoell
Copy link
Contributor

@cameronvoell cameronvoell commented Aug 14, 2020

Description from (#12679), cherry-picked commit into the new gutenberg/fix-classic-block-in-unsupported-editor-15.4.1-base branch with proper hotfix base (release/15.4.1).

This PR introduces a fix for the block editor for better support of the Classic Block.

Gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#2550

It's based on gb-mobile v1.33.1.

To test:

  1. Switch to html mode and write some text in-between two blocks, making sure the text is not inside the block delimiters
  2. Switch back to visual mode
  3. There should be an unsupported block displayed between the blocks the text was inserted
  4. Use the "?" button of the unsupported block and then "Edit block in web browser" to launch the Unsupported Block editor
  5. Notice the text being displayed inside a "Classic" block without an error 🎉
  6. Make some changes to the text and hit the "✔️" icon in the upper right to commit the changes
  7. Switch to html mode again and notice that the text includes the changes made inside the Unsupported Block editor 🎉

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Aug 14, 2020

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@cameronvoell cameronvoell requested a review from marecar3 August 14, 2020 22:20
@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APK here.

Copy link
Contributor

@marecar3 marecar3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Working as expected!

@cameronvoell cameronvoell merged commit e515c52 into gutenberg/integrate_hotfix_1.33.2 Aug 14, 2020
@marecar3 marecar3 deleted the gutenberg/fix-classic-block-in-unsupported-editor-15.4.1-base branch August 14, 2020 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants