Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate gutenberg hotfix release 1.32.1 #14649

Conversation

etoledom
Copy link
Contributor

@etoledom etoledom commented Aug 14, 2020

This PR introduces a fix for the block editor for better support of the Classic Block using the 1.32.1 release of gutenberg-mobile.

Gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#2551

To test: See WordPress/gutenberg#24571

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Aug 14, 2020

You can test the changes on this Pull Request by downloading it from AppCenter here with build number: 33021. IPA is available here. If you need access to this, you can ask a maintainer to add you.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Aug 14, 2020

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Aug 14, 2020

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@ceyhun ceyhun changed the base branch from release/15.3 to release/15.3.1 August 14, 2020 15:25
@ceyhun ceyhun marked this pull request as ready for review August 14, 2020 17:28
@ceyhun ceyhun added the Gutenberg Editing and display of Gutenberg blocks. label Aug 14, 2020
@ceyhun ceyhun changed the title Fix Classic Block in the Unsupported Block editor Integrate gutenberg hotfix release 1.32.1 Aug 17, 2020
Copy link
Contributor

@ceyhun ceyhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested according to WordPress/gutenberg#24571 and works great 🎉

@ceyhun
Copy link
Contributor

ceyhun commented Aug 19, 2020

Will target WPiOS 15.4 with 1.33.2 and 15.5 with 1.34.1 instead.

@ceyhun ceyhun closed this Aug 19, 2020
@ceyhun ceyhun deleted the gutenberg/fix-classic-block-in-unsupported-editor branch August 19, 2020 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants