[RNMobile] Fix for the Classic Block "null" inside Unsupported Block editor (target v1.32) #24571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.14 MB ℹ️ View Unchanged
|
6 tasks
etoledom
changed the base branch from
rnmobile/1.32.1
to
rnmobile/release-1.32.1
etoledom
added
the
Mobile App - i.e. Android or iOS
2 tasks
|
Looks like the "End-to-End Tests / Admin - 4 (pull_request) Failing after 14m — Admin - 4 " keep failing. I restarted the jobs a couple of times already with no luck. |
3 tasks
6 tasks
|
Will target WPiOS 15.4 with 1.33.2 and 15.5 with 1.34.1 instead. |
ceyhun
deleted the
rnmobile/24563-use-content-attribute-for-classic-block-in-ube-1.32
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24563
iOS version of #24569
This PR includes a fix for the native mobile Unsupported Blocks Fallback editor, to better support the Classic block. The fix consists of one change: to use the
contentattribute of the block for accessing the block content, instead of the.original_contentthat is for the rest of the blocks.Note: this PR is based on v1.32.0 of the native block editor with the goal of landing the fix on a 1.32.1 version to then land on WPiOS *v15.3. There's a accompanying GB PR based on v1.33.1 of gb-mobile to land on a v1.33.2 and then land on WPAndroid v15.4. Notice the difference in WP Apps and versions.
How has this been tested?
npm run start:reset)npm run core ios)Types of changes
When launching the Unsupported Block editor, provide the Classic block context available in the
contentattribute instead of theoriginal_contentattribute.Checklist: