Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to edit Classic block on mobile block editor #24563

Closed
guarani opened this issue Aug 13, 2020 · 3 comments · Fixed by #24602 or wordpress-mobile/gutenberg-mobile#2555
Closed

Unable to edit Classic block on mobile block editor #24563

guarani opened this issue Aug 13, 2020 · 3 comments · Fixed by #24602 or wordpress-mobile/gutenberg-mobile#2555
Assignees
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Status] In Progress Tracking issues with work in progress

Comments

@guarani
Copy link
Contributor

guarani commented Aug 13, 2020

Describe the bug
On mobile, the Unsupported Block fallback mechanism does not work with the Classic block.

To reproduce
Steps to reproduce the behavior:

  1. Create a post (on the web) that contains a Classic block and any other block
  2. Open the post inside the Gutenberg editor (on the WPiOS or WPAndroid apps)
  3. The unsupported block placeholder will appear in place of the Classic block as expected
  4. Tap the (?) button
  5. Tap the "Edit in web browser" button on the bottom sheet
  6. The Unsupported Block editor will open but will be blank ⚠️
  7. Tapping "Continue" to save and return to the block editor will erroneously remove the Classic block from the post ⚠️

Expected behavior

  • The Unsupported Block editor should support editing the Classic block
  • Tapping "Continue" to save inside the Unsupported Block editor should not remove the Classic block from the block editor

Screenshots

iOS Android

Editor version (please complete the following information):

  • WordPress version: [e.g: 5.3.2]
  • Does the website has Gutenberg plugin installed, or is it using the block editor that comes by default? [e.g: "gutenberg plugin", "default"]
  • If the Gutenberg plugin is installed, which version is it? [e.g., 7.6]

Smartphone (please complete the following information):

  • Device: iPhone 11 or Samsung S10
  • OS: iOS or Android
@guarani guarani added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Aug 13, 2020
@marecar3
Copy link
Contributor

Thanks @guarani !

@guarani
Copy link
Contributor Author

guarani commented Aug 17, 2020

@etoledom or @marecar3, could either of you please confirm whether this can be closed now? I see #24569 is merged.

@guarani
Copy link
Contributor Author

guarani commented Aug 17, 2020

Update: @etoledom or @marecar3 This was now closed but I see a pending PRs for 1.32.1 so not sure if this should actually be kept open now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Status] In Progress Tracking issues with work in progress
Projects
None yet
4 participants