Release 1.33.0 #2493
Release 1.33.0 #2493
Conversation
Change the bundle step to only create updated bundles and not get updates strings from the web. This way for code updates only we just need to run yarn bundle. For the releases we run yarn release:bundle. This will accelerate the builds for WP-Android and for WP-iOS it will allow deploy and test of PR that need bundle updates quicker.
# Conflicts: # package.json
…main Update Release doc references to main
Running the pod install could changes the lock file inside the GB repo so we need to run that before we commit the change in Gutenberg.
This reverts commit f4f5f78.
This reverts commit 5621583.
This reverts commit fffa925.
This reverts commit 7bb27c8.
…_color Create cover block with only colour
…lished # Conflicts: # gutenberg
…_drafts_are_not_published Ensure that empty posts are not published
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
|
I've done the following tests on Android (Pixel 3a) via this apk: https://62039-9306568-gh.circle-artifacts.com/0/Artifacts/WordPress-pr-12480-build-62039.apk Everything is working smoothly 🎉 The only minor note is that in one test case (group.md#tc008), the behavior differs from test, but I think the test case needs to be updated, since the behavior seems correct to me. Sanity tests - Android: DarkMode-1
Group-1
The behavior differs slightly from the test case expectation here, but I think the app's behavior is correct, and perhaps the test case merely needs to be updated (maybe the images too, or just a note that this has changed?).
since block icon is shown at root level (and the navigate up icon is not shown). Spacer-1
Buttons-1
Buttons-2
Buttons-3 Button-6 |
|
Sanity tests - iOS Gallery-1
Gallery-2
Gallery-3
NOTE: When have selected one of text style it works as long as the formatted word is not removed. After removing styling control is highlighted but the text is not styled.
🔴 break line doesn't work.
❓ I have one question: after test case
Columns - 2
Columns - 3
Columns - 4
MediaText-3
MediaText-4 MultipleUpload-1
Cover-1
Editor Theme - 1
Social Icons - 1
Social Icons - 2 |
That's a known issue(added this to the test steps):
I lost track of how the line break was supposed to work in captions, I am happy to update the test case accordingly if somebody tells me the latest state. @SergioEstevao knows maybe?
That's a good question, I think it is one of those things we don't have a complete win-win scenario. If we strip out failed media then we take away the ability to retry the upload easily. If we leave it this way then we'll see empty tiles because the media URL is the local url. IMO since the user clearly sees that the upload is failed they can easily make sense about why they see empty tiles. But I agree that this is not super ideal. I just don't have a better suggestion. |
Yep, because the preview is done on the server, and those images that failed are represented with local urls, this will happen.
So the current method (replicate the web) is that break lines don't work in the middle of the caption paragraphs, and if you do a break at the end of the caption text, it will insert a new paragraph bellow the block. |
Writing Flow tests on AndroidTLDR: Only issues I found were edge cases that existed before this release (noted below), so I don't see anything that would block the release. 🎉
|
Writing Flow tests on iOSFound no new issues 🎉
|
|
Looks like we've run all our sanity tests and there are no issues to block the release. 🙂 cc: @SergioEstevao |
|
For the record, I tested the folowing in WP-iOS and they are working correctly:
|
|
I tested the following on WPAndroid:
|
Release for Gutenberg Mobile 1.33.0
Related PRs
Gutenberg: GB-Mobile Release 1.33.0 WordPress/gutenberg#24050
WPAndroid: Update GB-mobile for release 1.33.0 WordPress-Android#12480
WPiOS: Update GB reference to 1.33.0 hash WordPress-iOS#14489
Aztec-iOS: NA
Aztec-Android: NA
Extra PRs that Landed After the Release Was Cut
Changes
Test plan
Release Submission Checklist
package.jsonandgutenberg/packages/react-native-editor/package.json.RNTAztecView.podspecandgutenberg/packages/react-native-aztec/RNTAztecView.podspec.RELEASE-NOTES.txtandgutenberg/packages/react-native-editor/RELEASE-NOTES.txtare updated with all the changes that made it to the release.