Ensure that empty posts are not published #2393
Conversation
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
|
👋 @SergioEstevao ! We're close to merging the monorepo changes 🎉 , and we will be cutting the release branches as soon as the monorepo changes are merged to gutenberg-mobile. As a result, we may be cutting the 1.31 release branches earlier than normal. Because every merge further delays the monorepo work (ends up requiring conflicts to be fixed and other work due to the monorepo feature branch and the squash policy in gutenberg), we want to cut the release branch with no further changes. For that reason, I'll bump this milestone to 1.32. Of course, if this has to make the 1.31 release, go ahead and move it back to the 1.31 milestone, and let me know. 🙇 |
|
👋 @SergioEstevao ! Since we're getting ready to cut the 1.32 branch, I'm bumping this to the 1.33. Obviously, feel free to undo that if this needs to make the 1.32 release. (Also, sorry I haven't reviewed this 😔) |
|
Is this PR still relevant? The original ticket it tries to address is closed by now. |
|
While the original issue is indeed closed, this PR was an improvement on top of the fix, in order to make the "Publish" completely disabled when the post was empty. Because of the way, we implemented this and after @etoledom reviewed it, we decide to not included in the original fix, because it involved changes on the auto-save mechanism that we feel we're not safe. Check the GB for more details on the implementation: WordPress/gutenberg#23233 |
…lished # Conflicts: # gutenberg
SergioEstevao
deleted the
issue/369_ensure_empty_drafts_are_not_published
branch
Fixes #369
This just updates the GB reference in order that empty posts autosaves are sent to the bridge method.
Check this GB PR for the changes: WordPress/gutenberg#23233
To test:
PR submission checklist:
RELEASE-NOTES.txtif necessary.