Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v1.18.0 #1627

Merged
merged 60 commits into from
Nov 29, 2019
Merged

Release v1.18.0 #1627

merged 60 commits into from
Nov 29, 2019

Conversation

maxme
Copy link
Contributor

@maxme maxme commented Nov 27, 2019 •
edited
Loading

Release for Gutenberg Mobile v1.18.0

Related PRs

Changes

Test plan

  • Use the main WP apps to test the changes above. See WPAndroid and WPiOS PRs if there are specific tests to run.
  • Smoke test the main WP apps for general writing flow.

etoledom and others added 30 commits November 7, 2019 08:16
@etoledom
Implement api-fetch middlewares
4a564b9
@etoledom
Add new init properties to iOS Bridge
7830e20 
siteSlug and extraHTTPHeaders were added to be used on apiFetch
@etoledom
Update gutenberg ref
4e9aa38
@etoledom
Add defaults to example app
8d81114
@etoledom
Remove the need for a custom fetchHandler
7ea196a
@etoledom
Use bridge to send a fetch request to client app
1797382
@etoledom
Modify bridge to handle fetch request
e366d01
@etoledom
Update example app
e3b8e72
@etoledom
Remove not-needed function name
e675c61
@etoledom
Update gutenberg ref
d9c910b
@etoledom
Merge remote-tracking branch 'origin/develop' into try/image-size-net…
97c47ac 
…working-native
@mchowning
Add Android native handling of api calls
a353978
@mchowning
Merge remote-tracking branch 'origin/release/1.17' into try/image-siz…
6c9e719 
…e-networking-native
@etoledom
[iOS Bridge] Change on fetch completion handler name
e6c77ee
@etoledom
[iOS Bridge] Adding code comments on gutenbergDidRequestFetch
0ac4672
@etoledom
Update iOS example app with changes on bridge
8bf3535
@mchowning
Have fetch handler immediately reject unsupported paths
a4aaac9 
Helps to avoid getting unexpected responses and hard to track down bugs:
wordpress-mobile/WordPress-iOS#12714 (comment)
@mchowning
Fix test
ea9b5d5
@mchowning
Merge remote-tracking branch 'origin/release/1.17' into try/image-siz…
c85adc7 
…e-networking-native
@etoledom
Adding resolver to apiFetch error case
ae30ed6
@etoledom
Fix lint error
52c89f1
@lukewalczak
RangeCell styling refactor (#1511)
1ef2a0f 
* Add ref to gutenberg repo
@Tug
Merge remote-tracking branch 'origin/develop' into master_develop_1.1…
443fba9 
…7_merge
@mchowning
Update gutenberg ref following 1.17 merge to gutenberg master
89c27cc
@mchowning
Merge pull request #1584 from wordpress-mobile/master_develop_1.17_merge
85f759c 
Master -> Develop (1.17)
@etoledom
Update gutenberg ref
e44264c
@etoledom
Merge remote-tracking branch 'origin/develop' into try/image-size-net…
9183a39 
…working-native
@SergioEstevao
Remove declaration on bridge of unused methods.
d268985
@cameronvoell
Added bridge code for gutenberg to request a native fullscreen previe…
69ba9c1 
…w for for an image from a URL on iOS.
@cameronvoell
Updating bundle and gutenberg reference.
0816eb4
etoledom and others added 12 commits November 22, 2019 10:53
@etoledom
Merge pull request #1598 from wordpress-mobile/issue/image-size-impro…
f44b4d7 
…vements-mark-i

Image Size improvements Mark I
@maxme
Update package.json and JS bundle for 1.18.0 release
c26e74d
Update Gutenberg ref
e0c1436
Update Release notes
d813bb4
@maxme
Merge pull request #1594 from wordpress-mobile/feature/enable-spacer-…
83e1190 
…block

Enable Spacer block in production
@maxme
Update gutenberg/ reference
6a849dc
@maxme
Update bundles
916994b
@maxme
Merge branch 'release/0.18.0' of https://github.com/wordpress-mobile/…
92f2f54 
…gutenberg-mobile into release/1.18.0
@Tug
Merge remote-tracking branch 'origin/develop' into master-merge-1.7.1
b9daba5
@Tug
Merge remote-tracking branch 'origin/release/1.18.0' into master-1.7.…
caf5a63 
…1-merge-to-release-1.18
@Tug
Bring back changes on package.json from 1.7.1
875e82f
@Tug
Merge pull request #1624 from wordpress-mobile/master-1.7.1-merge-to-…
2748621 
…release-1.18

Merge 1.17.1 -> 1.18.0 (v2)
This was referenced Nov 27, 2019
Merged
Merged
Merged
@maxme maxme marked this pull request as ready for review November 28, 2019 12:36
@maxme maxme requested review from etoledom and Tug November 28, 2019 12:36
cameronvoell
cameronvoell approved these changes Nov 29, 2019
View reviewed changes
Copy link
Contributor

@cameronvoell cameronvoell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified via WordPress iOS and Android testing as well as additional smoke tests, especially around last caption alignment fix, and fix on images with missing URLs. Looks good!

@maxme maxme merged commit 03b0941 into master Nov 29, 2019
@marecar3 marecar3 mentioned this pull request Dec 20, 2019
Merged
2 tasks
@SergioEstevao SergioEstevao deleted the release/1.18.0 branch May 22, 2020 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cameronvoell cameronvoell cameronvoell approved these changes

@marecar3 marecar3 Awaiting requested review from marecar3

@geriux geriux Awaiting requested review from geriux

@hypest hypest Awaiting requested review from hypest

@SergioEstevao SergioEstevao Awaiting requested review from SergioEstevao

@etoledom etoledom Awaiting requested review from etoledom

@Tug Tug Awaiting requested review from Tug

Assignees
No one assigned
Labels
release-process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@maxme @cameronvoell @etoledom @mchowning @lukewalczak @Tug @SergioEstevao