-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v1.19.1 #1710
Release v1.19.1 #1710
Conversation
Hey @planarvoid 👋
Yes, it seems that it's correct. Regarding this PR I have some comments:
You can see a nice pattern here: #1627 Note: We should also reference proper WPAndroid PR which will update WPAndroid app with the new version of aztec and especially a new version of the gb-mobile. Hey @etoledom, not sure if we need to update WPiOS as with |
Hey @marecar3, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anitaa and I have tested the changes in WPAndroid and everything seems to work as expected!
I merging this even though one of the tests is failing as it's not caused by this PR -> 🚢
This PR points to changes in Aztec. These changes don't touch any existing interfaces and only add new functionality so they shouldn't break anything.
Aztec changes - wordpress-mobile/AztecEditor-Android@807062a
We only want to merge this once the Aztec version is released.
Did I update the GB version correctly @hypest ?
Related PRs
Test Plan
PR submission checklist:
RELEASE-NOTES.txt
if necessary.