Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gutenberg: update to v1.18.0 #13010

Merged
merged 8 commits into from
Nov 29, 2019
Merged

Gutenberg: update to v1.18.0 #13010

merged 8 commits into from
Nov 29, 2019

Conversation

maxme
Copy link
Contributor

@maxme maxme commented Nov 27, 2019

Gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#1627

Changes:

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Nov 27, 2019 •
edited
Loading

You can trigger an installable build for these changes by visiting CircleCI here.

@maxme maxme added the Gutenberg Editing and display of Gutenberg blocks. label Nov 27, 2019
@maxme maxme mentioned this pull request Nov 27, 2019
Merged
@maxme maxme changed the title Gutenberg/integrate release 1.18.0 Gutenberg: update to v1.18.0 Nov 27, 2019
@maxme maxme added this to the 13.8 milestone Nov 27, 2019
@maxme
Copy link
Contributor Author

maxme commented Nov 28, 2019

✅ I tried to create a Spacer block and update the settings (with the updated range component)
✅ Tapping on a selected image open the full screen view.
✅ Smoke tested the writing flow.

SergioEstevao
SergioEstevao approved these changes Nov 28, 2019
View reviewed changes
Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run the following tests on iOS:

[x] Full screen preview of image
[x] Test different images size
[x] Tested the space block
[x] Generally tested the writing flow

All working fine! :shipit:

cameronvoell
cameronvoell approved these changes Nov 29, 2019
View reviewed changes
Copy link
Contributor

@cameronvoell cameronvoell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double checked that issue with images with missing URLs disappearing is gone after last gutenberg update. Smoke tests look good as well.

@maxme maxme merged commit a371219 into develop Nov 29, 2019
@pinarol pinarol assigned pinarol and unassigned pinarol Apr 13, 2020
@SergioEstevao SergioEstevao deleted the gutenberg/integrate_release_1.18.0 branch May 11, 2020 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cameronvoell cameronvoell cameronvoell approved these changes

@SergioEstevao SergioEstevao SergioEstevao approved these changes

@etoledom etoledom Awaiting requested review from etoledom

Assignees
No one assigned
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Milestone
13.8 ❄️
Development

Successfully merging this pull request may close these issues.
4 participants
@maxme @SergioEstevao @cameronvoell @pinarol