Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video block: Videos can't be played in private sites #5497

Closed
fluiddot opened this issue Feb 22, 2023 · 1 comment · May be fixed by #5553
Closed

Video block: Videos can't be played in private sites #5497

fluiddot opened this issue Feb 22, 2023 · 1 comment · May be fixed by #5553
Assignees
Labels

Comments

@fluiddot
Copy link
Contributor

fluiddot commented Feb 22, 2023

Describe the bug
Videos uploaded to private sites or videos marked as private can't be played in the editor via the Video block.

To Reproduce

  1. Go to a Simple site in WPCOM.
  2. Go to the Site Settings screen.
  3. Change Privacy to Private.
  4. Open a post/page.
  5. Add a Video block.
  6. Upload a video from the local device or record one.
  7. Once the upload finishes, tap on the video to play it.
  8. Observe that the video doesn't load and can't be played.

Expected behavior
Private videos should be playable within the Video block.

Screenshots

RPReplay_Final1677088758.MP4

Smartphone (please complete the following information):

  • Device: iPhone 11
  • OS: 15.4.1
  • Version: Jetpack 21.7.0.0

Additional context
This issue is caused because videos uploaded to Simple and Atomic sites are also added to VideoPress. On iOS, when fetching the video item, we use the VideoPress URL provided by the videos endpoint and the original response parameter. However, for playing private videos, we also need to pass a query parameter metadata_token with the token of that video. Otherwise, the request fails with error 403 Forbidden.

@SiobhyB
Copy link
Contributor

SiobhyB commented Feb 23, 2024

Fixed in Automattic/jetpack#35637.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done (keep clean, manually)
2 participants