[RNMobile] Video block: Fix logic for displaying empty state based on source presence #58015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.7 MB ℹ️ View Unchanged
|
derekblank
approved these changes
Jan 22, 2024
SiobhyB
pushed a commit
that referenced
this pull request
Jan 23, 2024
… source presence (#58015) * Avoid displaying Video block empty state when a source is present * Add tests to cover empty state visibility logic * Update `react-native-editor` changelog * Remove unneeded `await` statements from Video block unit tests * Update `react-native-editor` changelog
4 tasks
fluiddot
added a commit
that referenced
this pull request
Jan 26, 2024
* Release script: Update react-native-editor version to 1.111.0 * Release script: Update CHANGELOG for version 1.111.0 * Release script: Update podfile * [RNMobile] Video block: Fix logic for displaying empty state based on source presence (#58015) * Avoid displaying Video block empty state when a source is present * Add tests to cover empty state visibility logic * Update `react-native-editor` changelog * Remove unneeded `await` statements from Video block unit tests * Update `react-native-editor` changelog * Release script: Update react-native-editor version to 1.111.1 * Release script: Update CHANGELOG for version 1.111.1 * Release script: Update podfile * RNMobile: Avoid crashes by ensuring RichText value exists prior to `toString` calls (#58088) * [RNMobile] Remove `mediaFilesCollectionBlock` initial prop (#58140) * Remove `mediaFilesCollectionBlock` initial prop * Remove `enableMediaFilesCollectionBlocks` from Gutenberg demo app * Release script: Update react-native-editor version to 1.111.2 * Release script: Update CHANGELOG for version 1.111.2 * Release script: Update podfile --------- Co-authored-by: Siobhan <[email protected]>
3 tasks
This was referenced Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updates the condition in the Video Block that controls whether the empty state should be displayed. This PR follows the changes introduced in Automattic/jetpack#24548 and #49858. For the latter, seems it was the cause of the regression mentioned in #30987 (comment).
Why?
Fixes #30987.
How?
guidattribute is present.Warning
As mentioned in the inline comment, the
guidattribute is not defined in the block's schema. However, we are using it here as a temporary workaround.Testing Instructions
1 - Upload video
2 - Insert video from media library
3 - Save the post in the web version
Note
These instructions are extracted from Automattic/jetpack#24548.
WordPress.com site
Self-hosted site without Jetpack
In addition to confirming that the original bug is addressed, we should also confirm that there are no regressions to the way the video block appears for sites hosted outside of WordPress.com and without Jetpack.
4 - Insert video via URL
Note
These instructions are extracted from #49858.
To test #42515: Saving a Video block with a file URL displays placeholder text in the editor
http://commondatastorage.googleapis.com/gtv-videos-bucket/sample/ForBiggerFun.mp4To test #42443: Showing the play button after inserting URL that doesn't exist
aaaaaaTesting Instructions for Keyboard
N/A
Screenshots or screencast
N/A