Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Videos added from media library don't load in the editor #1151

Closed
rachelmcr opened this issue Jun 18, 2019 · 9 comments
Closed

Videos added from media library don't load in the editor #1151

rachelmcr opened this issue Jun 18, 2019 · 9 comments
Labels
HACK 7/2019 HACK week July 2019 [Type] Bug Something isn't working Video block

Comments

@rachelmcr
Copy link
Member

  1. Start a new block editor post in the app.
  2. Add a video block.
  3. Add a video from the site's media library.

Expected: The video will load in the editor with a play button.
Actual: All I see in the editor is a black rectangle.

The video was added to the post as expected (it loads when I view the actual post) but it never shows up in the editor. Videos I uploaded from the device or captured directly while in the editor appeared as expected, so the only issue seems to be with videos added from the media library.

image

Tested on iPhone XS, iOS 12.3.1, WPiOS 12.7.0.20190617

@rachelmcr rachelmcr added [Type] Bug Something isn't working [OS] iOS labels Jun 18, 2019
@pinarol
Copy link
Contributor

pinarol commented Jun 18, 2019

Hey @rachelmcr 👋

Is that happening every time? This blankness is about video not getting ready to play, as far as I know it was returning to normal after some updates on the post. But I know that it is annoying, so we already did some changes to make this better, for now I can suggest trying it again on the next release.

A bit detail on the issue:

The thing is, we are waiting for that "ready to play" state to show the play button. In the next release we changed this, it'll show the play button no matter what and tapping it will open the full screen player, user will see some loading indications there. Also I think it will re-trigger buffering and fix the preview. After that we might even need to do some more work to show the loading indication on the thumbnail as well, but it is hard to tell without trying the new version.

@rachelmcr
Copy link
Member Author

Is that happening every time? This blankness is about video not getting ready to play, as far as I know it was returning to normal after some updates on the post.

Yes, it's happening every time with different videos from my media library (including some small test videos that are only about 2 seconds long and 5 MB). I tried waiting, adding more content, saving the post, exiting and reopening the editor ... the videos never load or change.

It sounds like the next release will work better for me, but as it is the video block looks broken inside the editor when I add a video from my media library.

@pinarol
Copy link
Contributor

pinarol commented Jun 19, 2019

hey @rachelmcr 👋thanks for the extra info. I forgot to ask, is that happening on Atomic sites also? I think you are trying with a Premium site right?

@rachelmcr
Copy link
Member Author

I tested again and I see this issue on all WordPress.com Simple sites, regardless of plan. Other sites (WordPress.com Atomic, Jetpack, self-hosted) work as expected.

@hypest hypest added the HACK 7/2019 HACK week July 2019 label Jul 22, 2019
@designsimply
Copy link
Contributor

I tested today with 13.5-rc-1 (apk) on Pixel 3 Android 10 and on 13.5.0.0 beta (TestFlight) on iPhone 6S iOS 13.2 and found that I could see videos load with a play button in the block editor when added from the WordPress Media Library on a WordPress.com Premium site.

Screenshot_20191024-130116 IMG_3262
Tested with WPAndroid 13.4-rc-1 on Pixel 3 Android 10 and WPiOS 13.5.0.0 beta (TestFlight) on iPhone 6S iOS 13.2.

@rachelmcr
Copy link
Member Author

This is still an issue for me on a private WordPress.com Simple site in 13.5.0.20191021, on iPhone XS, iOS 13.1.3:

Although I do see a play button on the video now, when I tap it the video never loads:

But I also tested on a public site, and the video loaded there as expected.

Reopening because this is still an issue in some cases (and I confirmed that it works as expected in a browser on the private site).

@rachelmcr rachelmcr reopened this Oct 24, 2019
@rezzap
Copy link

rezzap commented Mar 14, 2020

I'm replicating this issue on both Android and iOS after a report from a user in Samsung Galaxy Tab A for both Premium plan site and free plan site.

Screenshot_20200314-080958_WordPress Image from iOS (2)

They also reported and it's being replicated that the media library thumbnails for videos show blank.

Screenshot_20200314-081025_WordPress

Replicated on Samsung Galaxy Tab A SM-T510, Android 9, WP app 14.4-rc-1
iPhone X MQAD2B/A iOS 13.3.1 WordPress app 14.3
User report in 2776496-zen

Also replicating the same behaviour in the published post as reported in #1909 and I'm not sure if this is related or not.

@ceyhun
Copy link
Contributor

ceyhun commented Apr 21, 2020

I was able to reproduce as well using a free public .com site.
On Android 14.5, Play Store version. Closing, saving and re-opening the draft didn't change anything.
On iOS 14.6, App Store version. Closing, saving and re-opening the draft fixed it!

@ceyhun ceyhun changed the title [iOS] Videos added from media library don't load in the editor Videos added from media library don't load in the editor Apr 21, 2020
@ceyhun ceyhun removed the [OS] iOS label Apr 21, 2020
@cameronvoell cameronvoell mentioned this issue Sep 3, 2020
5 tasks
@SiobhyB
Copy link
Contributor

SiobhyB commented Feb 13, 2024

As of 2024, this is only an issue for private sites, which is captured in #5497. I'll go ahead to close this one.

@SiobhyB SiobhyB closed this as completed Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HACK 7/2019 HACK week July 2019 [Type] Bug Something isn't working Video block
Projects
None yet
Development

No branches or pull requests

7 participants