Do not reject builds waiting for TestFlight review to avoid CI failure

[mokagio]

There is a known limitation in the ASC API that does not allow removing builds from TestFlight review, despite Fastlane offering a parameter to do so.

To avoid failures in CI in the (rare) occurrence of submitting a beta while another one is still waiting or in review, this PR disables rejecting builds.

Testing

Unfortunately, the only way to test this would be to create two beta one after the other and verify the TestFlight upload from CI does not fail for the second one. This is possible but "expensive" to do.

Regression Notes

1. Potential unintended areas of impact – N.A.
2. What I did to test those areas of impact (or what existing automated tests I relied on) – N.A.
3. What automated tests I added (or what prevented me from doing so) – N.A.

---

PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding unit tests for my changes. N.A.
• I have considered adding accessibility improvements for my changes. N.A.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary. N.A.

UI changes testing checklist: Not a UI PR.

[dangermattic]

	1 Warning
⚠️	PR is not assigned to a milestone.

Generated by 🚫 Danger

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.

	App Name	WordPress Alpha
	Configuration	Release-Alpha
	Build Number	pr23118-c1dc1c6
	Version	24.8
	Bundle ID	org.wordpress.alpha
	Commit	c1dc1c6
	App Center Build	WPiOS - One-Offs #9729

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.

	App Name	Jetpack Alpha
	Configuration	Release-Alpha
	Build Number	pr23118-c1dc1c6
	Version	24.8
	Bundle ID	com.jetpack.alpha
	Commit	c1dc1c6
	App Center Build	jetpack-installable-builds #8774

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[AliSoftware]

That's quite unfortunate.

Maybe we could contribute back to fastlane to apply this change to this code to fix the issue at its root at some point? (especially updating the filter + replacing waiting_for_review_build.beta_app_review_submission.delete! with waiting_for_review_build.expire! instead)?

[AliSoftware]

Approving to unblock, but I think it would be better to contribute to fastlane to apply the fix proposed by one of the commenters so that we can use that parameter it again?

[AliSoftware]

@mokagio Opened a PR to fix it in fastlane here: fastlane/fastlane#21995

Tested the fix with Tumblr-iOS alpha and beta builds today, as:

• They were similarly failing with those errors this morning (alpha, beta)
• But once I pointed my Gemfile to my fastlane's branch and tried creating a new alpha and beta, it detected the previous TestFlight build still in review and properly expired it.

[mokagio]

Approving to unblock, but I think it would be better to contribute to fastlane to apply the fix proposed by one of the commenters so that we can use that parameter it again?

Agreed. I would have looked into it, eventually 😅 Glad you got to it 👍

[AliSoftware]

Update: my fix fastlane/fastlane#21995 for this has shipped in fastlane 2.221.0 🎉 So that means we should be ok to re-enable this now (as long as we update fastlane too of course)

[mokagio]

Followed up with #23374