Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable reject_build_waiting_for_review after Fastlane upgrade #23374

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

mokagio
Copy link
Contributor

@mokagio mokagio commented Jun 19, 2024

Follows up on #23118 (comment) now that @AliSoftware's fastlane/fastlane#21995 has landed and shipped by re-enabling reject_build_waiting_for_review

I opened this against the release branch so we can see it in action sooner rather than later. However, to properly test this one would have to artificially submit two betas in short succession.

Luckily, @AliSoftware already tested the fix in the real world (see fastlane/fastlane#21995 description) so we can be quite confident in merging. Or, at least, as confident as anyone can be when interacting with the brittle ASC API...

Regression Notes

  1. Potential unintended areas of impact – N.A.
  2. What I did to test those areas of impact (or what existing automated tests I relied on) – N.A.
  3. What automated tests I added (or what prevented me from doing so) – N.A.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes. N.A.
  • I have considered adding accessibility improvements for my changes. N.A.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary. N.A.

UI changes testing checklist: Not a UI PR.

@dangermattic
Copy link
Collaborator

dangermattic commented Jun 19, 2024

1 Warning
⚠️ This PR is assigned to the milestone 25.1 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@mokagio mokagio added the Tooling Build, Release, and Validation Tools label Jun 19, 2024
@mokagio mokagio added this to the 25.1 ❄️ milestone Jun 19, 2024
@mokagio mokagio enabled auto-merge June 19, 2024 01:23
@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23374-47579c3
Version25.1
Bundle IDorg.wordpress.alpha
Commit47579c3
App Center BuildWPiOS - One-Offs #10191
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23374-47579c3
Version25.1
Bundle IDcom.jetpack.alpha
Commit47579c3
App Center Buildjetpack-installable-builds #9240
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@spencertransier spencertransier self-requested a review June 19, 2024 05:24
@mokagio mokagio merged commit 675d542 into release/25.1 Jun 19, 2024
24 of 26 checks passed
@mokagio mokagio deleted the mokagio/fastlane-2.221.0 branch June 19, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tooling Build, Release, and Validation Tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants