Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not reject builds waiting for TestFlight review to avoid CI failure #23118

Merged
merged 1 commit into from
May 1, 2024
Merged

Do not reject builds waiting for TestFlight review to avoid CI failure #23118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions fastlane/lanes/build.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,8 +434,12 @@ def upload_build_to_testflight(whats_new_path:, distribution_groups:)
changelog: File.read(whats_new_path),
distribute_external: true,
groups: distribution_groups,
# If there is a build waiting for beta review, we want to reject that so the new build can be submitted instead
reject_build_waiting_for_review: true
# If there is a build waiting for beta review, we ~~want~~ would like to to reject that so the new build can be submitted instead.
# Unfortunately, this is not (no longer?) possible via the ASC API.
# See https://github.com/fastlane/fastlane/issues/18408
#
# As a quick workaround to avoid CI failures, let's explicitly disable rejecting builds waiting for review.
reject_build_waiting_for_review: false
)
end

Expand Down
Loading