Merge fixes coming from 19.4 beta 2 #18136

mokagio · 2022-03-15T05:41:15Z

Includes:

Fix the ghost view not dismissing from the Insight tab under certain conditions (#18104) by @Gio2018
Fix an issue preventing users from changing their profile picture (#18132) by @guarani

Note that some of the translations are "incorrect". I've either addressed them in GlotPress or will do that "soon". If I don't get to it before you read this, I'd say we should merge the PR anyways. Otherwise, I'll run a new cycle of GlotPress downloads and all my notes about incorrect translations should disappear.

I'm keen on merging this even though the translations could be fixed in the context of this PR because:

I want to avoid conflicts with trunk
The sooner we get the beta fixes in trunk the better
There's no risk of forgetting about the translation issues because our automation will re-download them next time. Everything that's fixed will be fixed and if something hasn't been yet, we'll notice it in the diff.

…the CoreData fetch returned valid data

…ethod

…rdPress-iOS into issue-17904-insights-cards-not-showing

…cards-not-showing Fix ghost not disappearing from Insights cards in certain conditions

This bug fix works around a Photo Library permissions by opening the album selector instead of the "self-portraits" album.

peril-wordpress-mobile · 2022-03-15T05:41:20Z

	Messages
📖	This PR has the 'Releases' label: some checks will be skipped.

Generated by 🚫 dangerJS

mokagio · 2022-03-15T05:49:50Z

🤔 we got a UI tests failure on iPhone. By looking at the attached .xcresult, one can see the test crashed:

UI Test Activity:
Crash: backboardd (1773) 0x10726b000: Namespace SIGNAL, Code 0xb. dyld4 config: DYLD_ROOT_PATH=/Applications/Xcode-13.app/Contents/Developer/Platforms/iPhoneOS.platform/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS.simruntime/Contents/Resources/RuntimeRoot
CoreSimulator 776.3 - Device: iPhone 13 (79FE6B87-502C-4233-8A3B-70C5B688E4BE) - Runtime: iOS 15.0 (19A339) - DeviceType: iPhone 13

I restarted the tests.

mokagio

Updates to the localization files (.strings and Fastlane metadata) automatically pulled for the new translations that have already been approved in GlotPress
Version update in .xcconfig
Diffs from the PRs that made it into this beta

mokagio · 2022-03-15T05:51:16Z

RELEASE-NOTES.txt

@@ -12,6 +12,7 @@
 * [*] Weekly Roundup: We made some further changes to try and ensure that Weekly Roundup notifications are showing up for everybody who's enabled them [#18029]
 * [*] Block editor: Autocorrected Headings no longer apply bold formatting if they weren't already bold. [#17844]
 * [***] Block editor: Support for multiple color palettes [https://github.com/wordpress-mobile/gutenberg-mobile/pull/4588]
+* [**] User profiles: Fixed issue where the app wasn't displaying any of the device photos which the user had granted the app access to.


This was done knowingly of the fact the new entry wouldn't have made it in the editorialized copy: #18132 (comment)

mokagio · 2022-03-15T05:54:30Z

fastlane/metadata/ko/name.txt

@@ -1 +1 @@
-WordPress
+워드프레스 – 웹사이트 제작 도구


I've updated this at the GlotPress source.

Before:

After:

mokagio · 2022-03-15T05:56:03Z

fastlane/metadata/fr-FR/subtitle.txt

This is 31 characters, where it should be 30.

I don't know how to fix this I'll have to ask the i18n team.

mokagio · 2022-03-15T06:01:57Z

fastlane/metadata/ar-SA/name.txt

@@ -1 +1 @@
-WordPress
+ووردبريس – مُنشئ مواقع الويب


I "fixed" this at the GlotPress source. I'm not actually sure the way I wrote it is correct, but GlotPress marks my changed as waiting, so someone will look at it soon, hopefully.

Before:

After:

mokagio · 2022-03-15T06:03:14Z

fastlane/metadata/ar-SA/keywords.txt

This is less than the required 100 characters ✅

~~But I'm not sure about "jetpack" having been translated. I think the same rationale applies as WordPress...~~

~~I'll fix it at the source later, too.~~

Update: That "jetpack" keyword made me think these are the Jetpack app keywords, but they're the WordPress ones, as it's obvious once you look at the path 🤦

The new keywords do not include Jetpack. I run these through Google Translate and they match 👍 .

There is only one thing that's off and that's the use of Arabic commas instead of English one.

I updated that in the GlotPress source:

wpmobilebot · 2022-03-15T06:04:52Z

You can test the Jetpack changes on this Pull Request by downloading it from AppCenter here with build number: pr18136-94fa338. IPA is available here. If you need access to this, you can ask a maintainer to add you.

wpmobilebot · 2022-03-15T06:05:36Z

You can test the WordPress changes on this Pull Request by downloading it from AppCenter here with build number: pr18136-94fa338. IPA is available here. If you need access to this, you can ask a maintainer to add you.

AliSoftware

Changes from bugfix PRs which landed in the release branch
Version bump in .xcconfig files
Latest app and metadata translations pulled from GlotPress

I'm all good with merging the even if some of the metadata translations will have to be fixed later — especially since they are about store metadata (and not in-app translations in .strings files that would be visible to beta-testers).

As long as you took note that you'll have to loop back with i18n and polyglots to help fix them before you submit to the store on Friday, I don't see any harm in having them land in trunk for the time being. 👍

💭 PS: We could actually even argue if it really is useful to download store metadata during new_beta_release — well given current legacy tooling we can't really separate the two, but it's worth noting that with the new actions it is now possible so could be a thought to keep in mind, i.e. only download in-app translations during new_beta_release and only download both in-app and metadata translations during finalize_release 🤔 🤷

mokagio · 2022-03-15T20:25:39Z

💭 PS: We could actually even argue if it really is useful to download store metadata during new_beta_release — well given current legacy tooling we can't really separate the two, but it's worth noting that with the new actions it is now possible so could be a thought to keep in mind, i.e. only download in-app translations during new_beta_release and only download both in-app and metadata translations during finalize_release 🤔 🤷

That intriguing 🤔 I like the idea of not doing unnecessary work and to keep the beta merges diffs clean. At the same time, beta downloads allow us to discover issues early, like this PR shows. 🤔 🤔 🤔

Oh, and thank you for the review 🙇‍♂️

mokagio · 2022-03-16T02:58:44Z

fastlane/metadata/nl-NL/subtitle.txt

31 characters.

mokagio · 2022-03-16T03:00:05Z

fastlane/metadata/sv/subtitle.txt

35 characters

mokagio · 2022-03-16T06:10:40Z

fastlane/metadata/tr/name.txt

@@ -1 +1 @@
-WordPress
+WordPress – Web Sitesi Oluşturucu


33 characters

mokagio · 2022-03-16T06:13:02Z

fastlane/metadata/tr/subtitle.txt

34 characters

AliSoftware · 2022-03-16T10:12:23Z

At the same time, beta downloads allow us to discover issues early, like this PR shows.

Good point! Let's keep it then, it's not like the metadata download takes that much time anyway.

sla8c and others added 11 commits March 8, 2022 12:38

when loadFromCache() update the appropriate state status based on if …

5d0d509

…the CoreData fetch returned valid data

Update StatsInsightsStore, fix wrong comparisons in loadFromCache() m…

610c9ae

…ethod

Merge branch 'release/19.4' of https://github.com/wordpress-mobile/Wo…

8b3822e

…rdPress-iOS into issue-17904-insights-cards-not-showing

Merge pull request #18104 from wordpress-mobile/issue-17904-insights-…

27108ee

…cards-not-showing Fix ghost not disappearing from Insights cards in certain conditions

Allow users to change profile picture

0525342

This bug fix works around a Photo Library permissions by opening the album selector instead of the "self-portraits" album.

Add release notes for profile picture bug fix

8f2d076

Fix issue preventing users from changing profile picture (#18132)

422a490

Update translations

4ae87ac

Update metadata translations

51154c0

Update Jetpack metadata translations

dd3a071

Bump version number

94fa338

mokagio added the Releases label Mar 15, 2022

mokagio commented Mar 15, 2022

View reviewed changes

mokagio marked this pull request as ready for review March 15, 2022 06:03

mokagio added this to the 19.4 ❄️ milestone Mar 15, 2022

mokagio requested a review from a team March 15, 2022 06:05

AliSoftware approved these changes Mar 15, 2022

View reviewed changes

mokagio merged commit 4def945 into trunk Mar 15, 2022

This was referenced Mar 15, 2022

Fix issue preventing users from change profile picture #18132

Merged

Fix ghost not disappearing from Insights cards in certain conditions #18104

Merged

mokagio commented Mar 16, 2022

View reviewed changes

fastlane/metadata/nl-NL/subtitle.txt

Ontwerp een site, bouw een blog

Copy link

Contributor Author

mokagio Mar 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

31 characters.

mokagio commented Mar 16, 2022

View reviewed changes

fastlane/metadata/sv/subtitle.txt

Designa en webbplats, bygg en blogg

Copy link

Contributor Author

mokagio Mar 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

35 characters

mokagio commented Mar 16, 2022

View reviewed changes

fastlane/metadata/tr/name.txt

@@ -1 +1 @@

WordPress

WordPress – Web Sitesi Oluşturucu

Copy link

Contributor Author

mokagio Mar 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

33 characters

mokagio commented Mar 16, 2022

View reviewed changes

fastlane/metadata/tr/subtitle.txt

Bir site tasarla, bir blog oluştur

Copy link

Contributor Author

mokagio Mar 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

34 characters

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge fixes coming from 19.4 beta 2 #18136

Merge fixes coming from 19.4 beta 2 #18136

mokagio commented Mar 15, 2022 •

edited

Loading

peril-wordpress-mobile bot commented Mar 15, 2022

mokagio commented Mar 15, 2022

mokagio left a comment

mokagio Mar 15, 2022

mokagio Mar 15, 2022

mokagio Mar 15, 2022

mokagio Mar 15, 2022

mokagio Mar 15, 2022 •

edited

Loading

wpmobilebot commented Mar 15, 2022 •

edited

Loading

wpmobilebot commented Mar 15, 2022 •

edited

Loading

AliSoftware left a comment

mokagio commented Mar 15, 2022 •

edited

Loading

mokagio Mar 16, 2022

mokagio Mar 16, 2022

mokagio Mar 16, 2022

mokagio Mar 16, 2022

AliSoftware commented Mar 16, 2022

		@@ -1 +1 @@
		WordPress
		워드프레스 – 웹사이트 제작 도구

		@@ -1 +1 @@
		WordPress
		ووردبريس – مُنشئ مواقع الويب

Merge fixes coming from 19.4 beta 2 #18136

Merge fixes coming from 19.4 beta 2 #18136

Conversation

mokagio commented Mar 15, 2022 • edited Loading

peril-wordpress-mobile bot commented Mar 15, 2022

mokagio commented Mar 15, 2022

mokagio left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mokagio Mar 15, 2022 • edited Loading

Choose a reason for hiding this comment

wpmobilebot commented Mar 15, 2022 • edited Loading

wpmobilebot commented Mar 15, 2022 • edited Loading

AliSoftware left a comment

Choose a reason for hiding this comment

mokagio commented Mar 15, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AliSoftware commented Mar 16, 2022

mokagio commented Mar 15, 2022 •

edited

Loading

mokagio Mar 15, 2022 •

edited

Loading

wpmobilebot commented Mar 15, 2022 •

edited

Loading

wpmobilebot commented Mar 15, 2022 •

edited

Loading

mokagio commented Mar 15, 2022 •

edited

Loading