Fix ghost not disappearing from Insights cards in certain conditions

[Gio2018]

Fixes #17904

To test:
Pre-requisite: use a wp.com account with one or more site that have stats, preferably with many accesses

Testing:

1. Build/run and go to "My Site"
2. Tap on "Stats" then "Insights" (if you're not already there)
3. Screen should load normally
4. Navigate / back out to "My Site"
5. Repeat step 2
6. No ghost cards should appear

Regression Notes

1. Potential unintended areas of impact
   Stats -> Insights

2. What I did to test those areas of impact (or what existing automated tests I relied on)
   Manual test and run UI tests

3. What automated tests I added (or what prevented me from doing so)4.
   Some changes to the UI tests
   PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding unit tests for my changes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[Gio2018]

@mokagio this PR follows #18072 to fix the issues that cause ui tests to fail. Still draft for now, but wanted to let you know we're on it

[wpmobilebot]

You can test the Jetpack changes on this Pull Request by downloading it from AppCenter here with build number: pr18104-8b3822e. IPA is available here. If you need access to this, you can ask a maintainer to add you.

[wpmobilebot]

You can test the WordPress changes on this Pull Request by downloading it from AppCenter here with build number: pr18104-8b3822e. IPA is available here. If you need access to this, you can ask a maintainer to add you.

[mokagio]

Beautiful! Thank you @Gio2018. cc @tiagomar

[mokagio]

This fixes the ghost views appearing in the iPad UI tests 🎉 but the tests are still failing 🤔

The difference from #18072 is that they now all fail because the screen says "no data yet" in every field. Here's a screenshot from the CI .xcresult:

[sla8c]

Hey @Gio2018 the direction + outcome of all the new state status(es) being set need to be reversed.

Example for a single status - it should be like:
state.allTimeStats != nil ? .success : .error

OR
state.allTimeStats == nil ? .error : .success

Instead of:
state.allTimeStats != nil ? .error : .success

I made this mistake the first time and this was my first commit before I corrected it so I'm sure that's what has transpired.

Link to my correction here

[mokagio]

FYI, #18119, which addresses the UI tests issue, has been merged in the release branch.

A merge or rebase here should address the UI tests failures because of the "No data yet" and move along testing the new logic.

[sla8c]

LGTM!

[mokagio]

@Gio2018 this has been bundled as part of 19.4 beta 2 (19.4.0.2).

Thanks for your work 🙌