Merge changes from 19.4.0.1 beta #18115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…updates the default card list on insights for existing sites
…w default cards, and add property oldDefaultInsights to update default cards from previous versions
…ormation.updateDefaultInsights() at viewDidLoad() to update the default cards
… now renamed to upgradeInsights(), to also handle removing any .customize item saved in UserrDefaults
…teStatsInformation.upgradeInsights()
…-iOS into task/stats-revamp-reshuffle-cards
…huffle-cards Stats - Insights - Update Default cards list
…hen-creating-site FAB: show/hide when creating/deleting a site
Generated by 🚫 dangerJS |
mokagio
commented
Mar 10, 2022
This was referenced Mar 10, 2022
AliSoftware
approved these changes
Mar 10, 2022
There was a problem hiding this comment.
✅ Contains changes from the beta fixes which landed in release/* branch
✅ Latest .strings translations pulled from GlotPress
✅ release_notes.txt translated files emptied for the new version, in preparation for getting the new notes later in the sprint.
✅ Version bump in .xcconfig
| * [*] Stats: we fixed a variety of performance issues in the Insight screen. [#17926, #17936, #18017] | ||
| * [*] Stats: we re-organized the default view in Insights, presenting more interesting data at a glance [#18072] |
There was a problem hiding this comment.
Since this is a new entry, do you want to try to add mention of it to Grace's editorialized notes, or is it too late?
There was a problem hiding this comment.
For reference, see #18116 (comment):
I think it's fine to keep [the release notes] like this, but thank you for pointing them out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes:
Nothing to test, if CI Shows green, we're good. Note that the UI tests failure on iPad is expect and is being addressed in #18104.
Regression Notes
Potential unintended areas of impact
N.A.
What I did to test those areas of impact (or what existing automated tests I relied on)
N.A.
What automated tests I added (or what prevented me from doing so)
N.A.
RELEASE-NOTES.txtif necessary. N.A.