Fix issue preventing users from change profile picture

[guarani]

• Fixes Unable to change WP.com profile photo #18126
• Fixes [GlobalStep] Attempting to change a profile’s photo opens the “Recents” album on the first time only #13453

This PR is a workaround to fix an issue where the app froze and didn't show device photos when the user attempted to set their profile photo.

It also resolves a related issue where the app was opening different albums when the user attempts to change their profile photo (now the "Recents" album will always be opened when editing profile photos).

The app was freezing (and not showing device photos) because in code, we are not requesting permissions before calling into the PHPhotoLibrary.shared().register() function. This function call happened when the app filtered only for "selfie" photos, so eliminating that filter worked around the bug.

To fix the root cause involves calling requestAuthorization(for:handler:) before applying the filter. (There was recent work, see PR here, that appears to be related to this.)

My plan is to create a separate WPMediaPicker issue and follow up on that separately, after shipping this workaround.

I have no preference between the app opening the "Selfies" album or the "Recents" album, so I don't think this change has any negative consequences from a user's perspective (let me know if you think otherwise).

To test

The app should now always open the "Recents" album when changing the user's profile picture. Test each of the following scenarios and look for any issues.

- [ ] Fresh install, change profile photo during account creation (sign-up)
- [ ] Fresh install, change profile photo after login
- [ ] Fresh install, add media via My Site → Media
- [ ] Fresh install, log in, change profile photo, add media via My Site → Media
- [ ] Fresh install, log in, change profile photo, add media via image block within the block editor
- [ ] Fresh install, log in, change profile photo, change site icon (ensure it shows both media library photos **and** device photos) 
- [ ] Without reinstalling, try any combination of the above and look out for any issues

Regression Notes

1. Potential unintended areas of impact

The media picker is used in many places within the app and all . The test cases above include all known scenarios affected by the bug as well as scenarios where I checked for regressions

2. What I did to test those areas of impact (or what existing automated tests I relied on)

I relied on manual tests as specified in the above test plan.

3. What automated tests I added (or what prevented me from doing so)

I don't think adding automated tests here is feasible. Unless we mocked PHPhotoLibrary, the test would have a large external dependency. I think there's room for a unit test inside of the WPMediaPicker library, which we might be able to do once we address the root cause of this issue in a separate PR.

PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding unit tests for my changes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[wpmobilebot]

You can test the Jetpack changes on this Pull Request by downloading it from AppCenter here with build number: pr18132-8f2d076. IPA is available here. If you need access to this, you can ask a maintainer to add you.

[wpmobilebot]

You can test the WordPress changes on this Pull Request by downloading it from AppCenter here with build number: pr18132-8f2d076. IPA is available here. If you need access to this, you can ask a maintainer to add you.

[guarani]

Tested using build pr18132-0525342:

• Fresh install, change profile photo during account creation (sign-up)
• Fresh install, change profile photo after login
• Fresh install, add media via My Site → Media
• Fresh install, log in, change profile photo, add media via My Site → Media
• Fresh install, log in, change profile photo, add media via image block within the block editor
• Fresh install, log in, change profile photo, change site icon (ensure it shows both media library photos and device photos)
• Without reinstalling, try any combination of the above and look out for any issues

[peril-wordpress-mobile]

	Warnings
⚠️	This PR contains changes to RELEASE_NOTES.txt. Note that these changes won't affect the final version of the release notes as this version is in code freeze. Please, get in touch with a release manager if you want to update the final release notes.

Generated by 🚫 dangerJS

[guarani]

⚠️ This PR contains changes to RELEASE_NOTES.txt. Note that these changes won't affect the final version of the release notes as this version is in code freeze. Please, get in touch with a release manager if you want to update the final release notes.

The release notes can be left out since I don't think it's essential that they go into this release 👍
cc @mokagio

[momo-ozawa]

Tested the flows below. Works as described!

• Fresh install, change profile photo during account creation (sign-up)
• Fresh install, change profile photo after login
• Fresh install, add media via My Site → Media (Opens albums w recents at the top)
• Fresh install, log in, change profile photo, add media via My Site → Media
• Fresh install, log in, change profile photo, add media via image block within the block editor
• Fresh install, log in, change profile photo, change site icon (ensure it shows both media library photos and device photos)
• Without reinstalling, try any combination of the above and look out for any issues

[mokagio]

Thank you @guarani and @momo-ozawa 🙌

I'm going to take over merging this so we can ship a new beta today.

[mokagio]

@guarani this has been bundled as part of 19.4 beta 2 (19.4.0.2).

Thanks for your work 🙌

[guarani]

Thank you @momo-ozawa and @mokagio!