Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPhotoLibrary: Register change observer after asking for permission #376

Conversation

selanthiraiyan
Copy link
Contributor

@selanthiraiyan selanthiraiyan commented Jan 7, 2022

Fixes #375

Description

As proposed in https://developer.apple.com/forums/thread/696804 this PR register's PHPhotoLibrary change observer after asking for permission from the user.

Steps to test

  • Using Xcode 13.2.1 - Run the example app in a device/simulator running iOS 15.2 and make sure that you can access photos without any issues.
  • Also, make sure that the changes done to the photos library reflect in the app. (To ensure that the observer is working as expected)

Note: I have only tested the above points in a simulator and it would be great if you can test this in a device.

Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix! Thanks for this!

@SergioEstevao SergioEstevao added this to the 1.8.1 milestone Jan 10, 2022
@SergioEstevao
Copy link
Contributor

@jkmassel I've tested this fix and it solves a critical crash on WPMediaPicker for iOS version 15.2

After this PR is merged we should create a new version of the pod and update all the projects that use this pod.

From what I see the issue identified only happens when the apps are installed for the first and it request permissions to access the device Media library. So this may not affect existing users, but can/will affect new users of the apps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Xcode 13.2.1 - Photos not loading in iOS 15.2 simulator
2 participants