My Site Dashboard: Add site picker to MySite screen only once #17814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can trigger an installable build for these changes by visiting CircleCI here. |
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
added 4 commits
January 26, 2022 15:27
This fixes a bug where a sitePicker was getting added to the layout every time a user switched sites.
If the MSD feature flag is enabled, the current blog should be the SitePickerVC's blog -- since the SitePickerVC is responsible for updating the currently selected blog.
Also, extracted the updateChildViewController method to handle updating whichever child vc is currently being shown.
momo-ozawa
force-pushed
the
fix/msd-site-picker-duplication
branch
from
cff3fb0 to
1b3ff59
Compare
leandroalonso
approved these changes
Jan 26, 2022
| stackView.insertArrangedSubview(sitePickerViewController.view, at: 0) | ||
| sitePickerViewController.didMove(toParent: self) | ||
| } | ||
|
|
||
| private func setupSegmentedControl() { |
There was a problem hiding this comment.
FYI: we shouldn't show the segmented control for self-hosted sites. Not sure if this is planned for a future task, but it might be good to add it as a subtask so we won't forget about it. :)
There was a problem hiding this comment.
Created an issue! #17825
This was referenced Feb 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17813
Description
This PR fixes the following:
How to test
Make sure the My Site Dash feature flag is enabled.
Site Picker should be added only once
Simulator.Screen.Recording.-.iPhone.13.-.2022-01-25.at.19.26.24.mp4
Switching to the dashboard
Simulator.Screen.Recording.-.iPhone.13.-.2022-01-26.at.15.55.42.mp4
Regression Notes
PR submission checklist:
RELEASE-NOTES.txtif necessary.