Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title and URL aren't updated after creating WP.com site #17993

Closed
twstokes opened this issue Feb 19, 2022 · 2 comments · Fixed by #17995
Closed

Title and URL aren't updated after creating WP.com site #17993

twstokes opened this issue Feb 19, 2022 · 2 comments · Fixed by #17995

Comments

@twstokes
Copy link
Contributor

Expected behavior

After creating a new WP.com site, the site title and URL are updated on the My Site view.

Actual behavior

After creating a new WP.com site, the site title and URL aren't updated on the My Site view.

Steps to reproduce the behavior

  1. Have an existing site loaded in the My Site view
  2. Create a new WP.com site
  3. Observe that the title and URL of the previous site remain in the My Site view
Site.Creation.mp4
Tested on iPhone 13 Simulator, iOS 15.2, WPiOS 19.2
@twstokes twstokes changed the title Title and URL aren't updated after creating a WP.com site Title and URL aren't updated after creating WP.com site Feb 19, 2022
@twstokes
Copy link
Contributor Author

twstokes commented Feb 19, 2022

Hi @momo-ozawa and @leandroalonso 👋! While troubleshooting this error (as well as #17982), I spotted that in #17814 we're no longer adding a SitePickerViewController if one already exists in the MySiteViewController. addSitePickerIfNeeded(for blog: Blog) is called in the blog setter.

I wonder if perhaps this change is blocking updates when the title and URL need to be updated? Thanks for any insight!

@momo-ozawa
Copy link
Contributor

Hi @twstokes -- the title and url weren't being updated because we weren't updating the blog for SitePickerViewController if SitePickerViewController already exists. Thanks for alerting us about this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants