Merge 18.7.0.1 (beta 2) into develop
#17562
Conversation
Fix UserInfo Crash
…nment Reply text view: fix content vertical alignment.
Comments: fix empty view vertical placement.
|
You can trigger an installable build for these changes by visiting CircleCI here. |
| ووردبريس أسرع وأكثر أمانًا |
| WordPress – schneller und sicherer |
| WordPress más rápido y seguro |
| WordPress plus sûr, plus rapide |
| Faster, safer WordPress |
There was a problem hiding this comment.
This obviously hasn't been translated yet
| WordPress lebih cepat dan aman |
There was a problem hiding this comment.
30 characters ✅, just 😅
| WordPress più veloce e più sicuro |
There was a problem hiding this comment.
33 characters ❌
I'll update in GlotPress to "WordPress più veloce e sicuro" which means the same in Italian and is 29 characters.
| より速く安全な WordPress |
There was a problem hiding this comment.
17 characters ✅
That is if App Store Connect does something like "...".length, which would make sense to me given that the 30 characters limitation is not a matter of sentence complexity but of screen real estate. I'm not actually sure if Japanese strings kanji are counted in the same way as we do with the letters in a Roman language.
| 더 빠르고 더 안전한 워드프레스 |
There was a problem hiding this comment.
17 characters ✅
That is if App Store Connect does something like "...".length, which would make sense to me given that the 30 characters limitation is not a matter of sentence complexity but of screen real estate. I'm not actually sure if Korean characters are counted in the same way as we do with the letters in a Roman language.
| Sneller, veiliger WordPress |
| O WordPress mais ágil e seguro |
| Более быстрый и безопасный WordPress |
| Snabbare, säkrare WordPress |
| Daha hızlı, daha güvenli bir WordPress |
| 更快速、更安全的 WordPress |
There was a problem hiding this comment.
18 characters ✅
That is if App Store Connect does something like "...".length, which would make sense to me given that the 30 characters limitation is not a matter of sentence complexity but of screen real estate. I'm not actually sure if Chinese characters are counted in the same way as we do with the letters in a Roman language.
| 更快速安全的 WordPress 體驗 |
There was a problem hiding this comment.
19 characters ✅
That is if App Store Connect does something like "...".length, which would make sense to me given that the 30 characters limitation is not a matter of sentence complexity but of screen real estate. I'm not actually sure if Chinese characters are counted in the same way as we do with the letters in a Roman language.
There was a problem hiding this comment.
Can confirm that's how they're counted 🙂
There was a problem hiding this comment.
Oh, thank you for checking ❤️ TIL
Generated by 🚫 dangerJS |
AliSoftware
changed the title
developdevelop
There was a problem hiding this comment.
Looking good.
Approving despite some subtitles being >30 because you already made a request in +i18n to ask them to be fixed by translators (ref: pxLjZ-6GO-p2) so best scenario they're gonna be fixed by the time you submit on Friday, and worst case you'll just skip updating them this time around and hope they get fixed for the next.
PS: Edited the PR's title which was mentioning 18.7.0.2 while this is 18.7.0.1 (beta 2, but zero-based versioning, yadda yadda)
Lol. Yeah I should have actually called this beta 1 (with code freeze being beta 0). I think in my mind doing the first beta on the Thursday before finalization was just too weird and my subconscious just assumed this was another one 🤣 Thanks for fixing it. |
I made this to ship a build with the most up-to-date translations we have to help smoke testing them in the app.
Includes:
Also notice the new subtitles for Jetpack, and that quite a few of them go over the 30 characters limit 😞
The request for the translator is visible in GlotPress, albeit not "in your face". It would be nice if we could have some kind of annotation in the
.pofile that GlotPress can read and use to enforce a characters threshold.