-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge finalized release 18.7 into develop
#17573
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Fastlane localized
release_notes.txt
updates - Localized
.strings
updates – A few new ones came in since beta 2 + binary files have been touched - Build number bump in version
.xcconfig
file
WordPress più veloce e sicuro |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Submitted by yours truly 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
PS: I'm assuming you mean you submitted this in GlotPress itself at its source (as opposed to manually changing the content of the .txt
)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. Did it via GlotPress 😄
שירות מהיר יותר ובטוח יותר ב-WordPress |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This hadn't yet been translated at the time of #17562. It turned out to be 38 characters.
Before running the ASC metadata update step, I deleted this and the other > 30 characters entries from my machines, to avoid validation errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- ✅ Version bump in
xcconfig
- ✅ latest app Localizations pulled
- ✅ Release Notes & new AppStore subtitles translations updated too
LGTM,
PS: Can't wait to get to start migrating the localization of WordpressTodayWidget
and WordPressShareExtension
in the app's strings like I did for the WordPressStatsWidgets
in https://github.com/wordpress-mobile/WordPress-iOS/pull/17570… so that I can finally delete all those Localizable.strings
files in those targets' directory and they stop pulluting those release PRs 😅
WordPress più veloce e sicuro |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
PS: I'm assuming you mean you submitted this in GlotPress itself at its source (as opposed to manually changing the content of the .txt
)?
At the time of opening this, the latest Gutenberg version PR, #17563, is almost ready to merge — Buildkite is building and is going through the slow Pods step because of the new version.
I have opened this against
develop
, because I'm pretty sure there won't be any merge conflicts once that PR lands, since this branch doesn't change the three files touched in the other.