Fix UserInfo Crash

[illusaen]

Fixes a crash where cloning the userInfo of an NSError is causing a Core Data exception when trying to save the context.

2021-11-17 14:10:31:827 WordPress[1434:200461] Unresolved Core Data save error: Error Domain=NSCocoaErrorDomain Code=134060 "A Core Data error occurred." UserInfo={NSUnderlyingError=0x120604370 {Error Domain=NSCocoaErrorDomain Code=4866 "The data couldn’t be written because it isn’t in the correct format." UserInfo={NSUnderlyingError=0x120618770 {Error Domain=NSCocoaErrorDomain Code=4864 "This decoder will only decode classes that adopt NSSecureCoding. Class 'NWConcrete_nw_path' does not adopt it." UserInfo={NSDebugDescription=This decoder will only decode classes that adopt NSSecureCoding. Class 'NWConcrete_nw_path' does not adopt it.}}}}}

To test:

Prerequisites: iOS 15

1. Go to a simple site.
2. Put the device into Airplane Mode.
3. Add an image block to a post.
4. Select an image from the device.
5. See that it doesn't crash and a "Failed to insert media. Please tap for options." message is displayed.

Regression Notes

1. Potential unintended areas of impact
   Error should still exist and show that there was a networking error, just without crashing.

2. What I did to test those areas of impact (or what existing automated tests I relied on)
   Use the above steps to test.

3. What automated tests I added (or what prevented me from doing so)
   N/A

PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding unit tests for my changes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[peril-wordpress-mobile]

You can trigger an installable build for these changes by visiting CircleCI here.

[twstokes]

Interestingly the crash doesn't occur (nor the errors) if the original NSError is used. Comparing the "custom" error to the original, only the descriptions differ (because that's what we inject). The NSUnderlyingError key in the userInfo dictionary appears to be the culprit. Possibly the fact that its value is an object is a clue.

[peril-wordpress-mobile]

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

[twstokes]

I also want to note that I failed to find any spots in code where we cared about anything more than the domain, code, and description when dealing with Media errors.

[ScoutHarris]

✅ See that it doesn't crash and a "Failed to insert media. Please tap for options." message is displayed.