Empty Stats: AB test the nudges order #17328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can trigger an installable build for these changes by visiting CircleCI here. |
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
momo-ozawa
force-pushed
the
feature/empty-stats-phase-1
branch
from
9efabd9 to
347263c
Compare
momo-ozawa
approved these changes
Oct 15, 2021
There was a problem hiding this comment.
Works as described!
social appears first. Do you think we should call it publicize instead?
2021-10-15 17:30:42:672 WordPress[17788:664620] 🔵 Tracked: stats_publicize_nudge_shown <blog_id: 198007634, first_nudge: social, site_type: blog>
2021-10-15 17:30:57:995 WordPress[17788:664620] 🔵 Tracked: stats_publicize_nudge_tapped <blog_id: 198007634, first_nudge: social, site_type: blog>
2021-10-15 17:31:05:610 WordPress[17788:664620] 🔵 Tracked: stats_publicize_nudge_dismissed <blog_id: 198007634, first_nudge: social, site_type: blog>
Definitely! I'll change it. |
leandroalonso
force-pushed
the
task/add_ab_test_for_nudges_order
branch
from
def7bad to
5610947
Compare
momo-ozawa
approved these changes
Oct 15, 2021
| @@ -9,7 +9,6 @@ | |||
| * [**] Block editor: Embed block: Detect when an embeddable URL is pasted into an empty paragraph. [https://github.com/wordpress-mobile/gutenberg-mobile/pull/4048] | |||
| * [**] Block editor: Pullquote block - Added support for text and background color customization [https://github.com/WordPress/gutenberg/pull/34451] | |||
| * [**] Block editor: Preformatted block - Added support for text and background color customization [https://github.com/wordpress-mobile/gutenberg-mobile/pull/4071] | |||
| * [**] Stats: added Publicize and Blogging Reminders nudges for sites with low traffic in order to increase it. | |||
| @@ -652,9 +652,11 @@ extension SiteStatsInsightsTableViewController: NoResultsViewHost { | |||
| private extension SiteStatsInsightsTableViewController { | |||
|
|
|||
| func trackNudgeEvent(_ event: WPAnalyticsEvent) { | |||
| let firstNudge: String = EmptyStatsAB.shared.variant == .control ? "publicize" : "bloggingReminder" | |||
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only merge after #17313
To test
first_nudgeis fired with the correct valueRegression Notes
PR submission checklist:
RELEASE-NOTES.txtif necessary.