Empty Stats: Add event tracking for Publicize / Blogging Reminders #17313

momo-ozawa · 2021-10-13T16:57:35Z

Description

This PR adds event tracking for the following events:

// Stats - Empty Stats nudges

stats_publicize_nudge_shown
stats_publicize_nudge_tapped
stats_publicize_nudge_dismissed
stats_publicize_nudge_completed
stats_blogging_reminders_nudge_shown
stats_blogging_reminders_nudge_tapped
stats_blogging_reminders_nudge_dismissed
stats_blogging_reminders_nudge_completed

// Stats - Customize card

stats_customize_insights_shown

To test

To review this PR, please do the following:

Make sure events fire correctly by following the trigger in the table below
Validate the events (PCYsg-ktp-p2)

What does it mean for an event to be valid?

An event can be marked valid when you’ve checked that it:
Fires when it’s supposed to.
Fires exactly once each time it’s supposed to fire.
Has a blogid set if the event takes place in a site context.  If it’s not in a site context (e.g. a landing page or the wpcom homepage), you can omit a blogid.
Has the event properties that you intend it to have, and that are being attached to the event by your code.
Who should review it?

Similarly to code reviews, someone on your team or working in the same area as you is probably best to review your event.

Event table

Event	Trigger	blog_id?
stats_publicize_nudge_shown	Publicize card is shown upon visiting the Stats Insights screen	✅
stats_publicize_nudge_tapped	Tapping on the `Enable post sharing` button on the Publicize card	✅
stats_publicize_nudge_dismissed	Tapping on the `Dismiss` button on the Publicize card	✅
stats_publicize_nudge_completed	Successfully setting up at least one connection via Publicize	✅
stats_blogging_reminders_nudge_shown	Blogging Reminders card is shown upon visiting the Stats Insights screen	✅
stats_blogging_reminders_nudge_tapped	Tapping on the `Set up blogging reminders` button on the Blogging Reminders card	✅
stats_blogging_reminders_nudge_dismissed	Tapping on the `Dismiss` button on the Blogging Reminders card	✅
stats_blogging_reminders_nudge_completed	Successfully setting up Blogging Reminders via the Blogging Reminders flow	✅
stats_customize_insights_shown	Customize Insights card is shown upon visiting the Stats Insights screen	❌

Regression Notes

Potential unintended areas of impact
N/A
What I did to test those areas of impact (or what existing automated tests I relied on)
Manually tested and made sure events fire properly with the correct triggers / properties
What automated tests I added (or what prevented me from doing so)
N/A

PR submission checklist:

I have completed the Regression Notes.
I have considered adding unit tests for my changes.
I have considered adding accessibility improvements for my changes.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

peril-wordpress-mobile · 2021-10-13T16:57:40Z

You can trigger an installable build for these changes by visiting CircleCI here.

momo-ozawa · 2021-10-14T10:01:48Z

Notes

I'll add the nudge_dismissed events after Nikola's fix presentation logic PR lands. The plan is to track the events in the individual dismiss nudge methods for SiteStatsInsightsDelegate -> ✅

peril-wordpress-mobile · 2021-10-14T10:14:11Z

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

…ize card

The default view count 0 was being supplied to itemToDisplay, which was causing .social to be returned when it should have been returning nil.

This reverts commit b4fb243.

momo-ozawa · 2021-10-15T11:39:14Z

Reverted b4fb243 because it was causing the presentation logic to break.
Added a workaround in c74d496 to make sure the shown events are fired only once.

nikola-milicevic

Great work!
Since you've already cleaned up some of my code 😄 could you just please get rid of nil coalescing operator here?
And case let syntax would be great here as well! (so I don't have to do this)

I have just two concerns:

stats_blogging_reminders_nudge_shown wasn't triggered for me 😬, I will check again (few times)
didChangePublicizeServices method of SharingViewControllerDelegate could fire even if there are no changes (but that's not the scope of this PR - just pointing out here)

nikola-milicevic · 2021-10-15T11:28:07Z

WordPress/Classes/ViewRelated/Stats/Insights/SiteStatsInsightsTableViewController.swift

-            case is GrowAudienceCell.HintType where !insightsToShow.contains(.growAudience):
+            case let hintType as GrowAudienceCell.HintType where !insightsToShow.contains(.growAudience):


leandroalonso

@momo-ozawa it worked just fine for all the described events, except for the blogging reminders nudge appearing. No events are fired at all.

At least here, inside loadPinnedCards the execution is hitting the break. Let me know if you need more info!

leandroalonso · 2021-10-15T12:11:59Z

WordPress/Classes/ViewRelated/Stats/Insights/SiteStatsInsightsTableViewController.swift

            case InsightType.customize where !insightsToShow.contains(.customize):
                insightsToShow = insightsToShow.filter { $0 != .growAudience }
                insightsToShow.insert(.customize, at: 0)
+
+                // Work around to make sure customize insights shown is tracked only once


Is this to prevent the event from being fired multiple times?

if that's the case, this is something we should not be worried about, given that normally we look at "unique" events.

Actually, this is a workaround to make sure the correct event will be fired once.

If you go to a site with more than 30 views (i.e. customize should be showing) and comment out the if viewsCount != nilstatement, you'll see that the publicize_nudge_shown event is fired right before the correct event, customize_insights_shown.

I tried doing b4fb243 in an attempt to fix this behavior, but that actually ended up breaking the presentation logic. (after dismissing a card, the next card shown would be the incorrect card, etc.) Maybe @nikola-milicevic has some insight on how to address this issue without breaking the presentation logic?

Oh ok! If that's the case then don't worry. Just wanted to make sure.

nikola-milicevic

stats_blogging_reminders_nudge_shown wasn't triggered for me 😬, I will check again (few times)

Checked again, few times, all good 😊
Not sure what happened.

leandroalonso · 2021-10-15T12:15:33Z

stats_blogging_reminders_nudge_shown wasn't triggered for me 😬, I will check again (few times)

I have the same issue 😬

leandroalonso · 2021-10-15T12:17:26Z

FYI:

momo-ozawa · 2021-10-15T13:18:45Z

@momo-ozawa it worked just fine for all the described events, except for the blogging reminders nudge appearing. No events are fired at all.

At least here, inside loadPinnedCards the execution is hitting the break. Let me know if you need more info!

🤯 Hmmmm. Looking into this. So weird -- in your screenshot item evaluates to .bloggingReminders, which should be caught by the case let hintType as GrowAudienceCell.HintType... statement. Hmmmmm.

This fixes an issue where the following condition was failing: where !insightsToShow.contains(.growAudience)

momo-ozawa · 2021-10-15T15:15:59Z

@leandroalonso @nikola-milicevic
Ready for a re-review! The mysterious bug where blogging_reminders_nudge_shown wasn't being fired has been fixed!
94d4b9e

leandroalonso

@momo-ozawa

I also validated all the events.

momo-ozawa added Stats [Type] Task labels Oct 13, 2021

momo-ozawa added this to the Someday milestone Oct 13, 2021

momo-ozawa self-assigned this Oct 13, 2021

momo-ozawa force-pushed the task/empty-stats-events branch from 27648b0 to 82f9684 Compare October 14, 2021 09:57

Momo Ozawa added 10 commits October 15, 2021 09:12

Add: events for publicize nudge, blogging reminders nudge, and custom…

68b7110

…ize card

Add: extension method to track nudge event

7c3148a

Add: track nudge tapped for publicize

80dc1e3

Add: track nudge tapped for blogging reminders

32434b5

Add: track nudge completed for publicize

941d7c5

Add: track nudge completed for blogging reminders

d75d3db

Add: track card shown for customize insights

1907b9c

Add: track nudge shown for publicize and blogging reminders

abffcf1

Add: track nudge dismissed for publicize and blogging reminders

c887490

Fix: return nil for itemToDisplay if view count is also nil

b4fb243

The default view count 0 was being supplied to itemToDisplay, which was causing .social to be returned when it should have been returning nil.

momo-ozawa force-pushed the task/empty-stats-events branch from 60a3d9d to b4fb243 Compare October 15, 2021 09:18

momo-ozawa requested review from nikola-milicevic and leandroalonso October 15, 2021 09:32

momo-ozawa marked this pull request as ready for review October 15, 2021 09:33

Momo Ozawa added 2 commits October 15, 2021 12:33

Revert "Fix: return nil for itemToDisplay if view count is also nil"

64d12ac

This reverts commit b4fb243.

Fix: workaround to make sure shown events are fired only once

c74d496

nikola-milicevic reviewed Oct 15, 2021

View reviewed changes

leandroalonso requested changes Oct 15, 2021

View reviewed changes

nikola-milicevic approved these changes Oct 15, 2021

View reviewed changes

nikola-milicevic force-pushed the task/empty-stats-events branch from 4f78e81 to 8b9b022 Compare October 15, 2021 15:01

Change RELEASE-NOTES

74e47ec

nikola-milicevic force-pushed the task/empty-stats-events branch from 8b9b022 to 74e47ec Compare October 15, 2021 15:02

Momo Ozawa added 2 commits October 15, 2021 16:05

Fix: remove growAudience from insightsToShow if nudge is completed

94d4b9e

This fixes an issue where the following condition was failing: where !insightsToShow.contains(.growAudience)

Update: add relevant PRs to release notes

9f6da61

leandroalonso mentioned this pull request Oct 15, 2021

Empty Stats: AB test the nudges order #17328

Merged

4 tasks

leandroalonso approved these changes Oct 15, 2021

View reviewed changes

momo-ozawa merged commit 9efabd9 into feature/empty-stats-phase-1 Oct 15, 2021

momo-ozawa deleted the task/empty-stats-events branch October 15, 2021 15:31

momo-ozawa mentioned this pull request Oct 15, 2021

Empty Stats (Phase 1): Publicize and Blogging Reminders #17329

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Empty Stats: Add event tracking for Publicize / Blogging Reminders #17313

Empty Stats: Add event tracking for Publicize / Blogging Reminders #17313

momo-ozawa commented Oct 13, 2021 •

edited

Loading

peril-wordpress-mobile bot commented Oct 13, 2021 •

edited

Loading

momo-ozawa commented Oct 14, 2021 •

edited

Loading

peril-wordpress-mobile bot commented Oct 14, 2021 •

edited

Loading

momo-ozawa commented Oct 15, 2021

nikola-milicevic left a comment •

edited

Loading

nikola-milicevic Oct 15, 2021

leandroalonso left a comment •

edited

Loading

leandroalonso Oct 15, 2021

momo-ozawa Oct 15, 2021

leandroalonso Oct 15, 2021

nikola-milicevic left a comment

leandroalonso commented Oct 15, 2021

leandroalonso commented Oct 15, 2021

momo-ozawa commented Oct 15, 2021

momo-ozawa commented Oct 15, 2021

leandroalonso left a comment

		case is GrowAudienceCell.HintType where !insightsToShow.contains(.growAudience):
		case let hintType as GrowAudienceCell.HintType where !insightsToShow.contains(.growAudience):

Empty Stats: Add event tracking for Publicize / Blogging Reminders #17313

Empty Stats: Add event tracking for Publicize / Blogging Reminders #17313

Conversation

momo-ozawa commented Oct 13, 2021 • edited Loading

Description

To test

Event table

Regression Notes

peril-wordpress-mobile bot commented Oct 13, 2021 • edited Loading

momo-ozawa commented Oct 14, 2021 • edited Loading

Notes

peril-wordpress-mobile bot commented Oct 14, 2021 • edited Loading

momo-ozawa commented Oct 15, 2021

nikola-milicevic left a comment • edited Loading

Choose a reason for hiding this comment

nikola-milicevic Oct 15, 2021

Choose a reason for hiding this comment

leandroalonso left a comment • edited Loading

Choose a reason for hiding this comment

leandroalonso Oct 15, 2021

Choose a reason for hiding this comment

momo-ozawa Oct 15, 2021

Choose a reason for hiding this comment

leandroalonso Oct 15, 2021

Choose a reason for hiding this comment

nikola-milicevic left a comment

Choose a reason for hiding this comment

leandroalonso commented Oct 15, 2021

leandroalonso commented Oct 15, 2021

momo-ozawa commented Oct 15, 2021

momo-ozawa commented Oct 15, 2021

leandroalonso left a comment

Choose a reason for hiding this comment

momo-ozawa commented Oct 13, 2021 •

edited

Loading

peril-wordpress-mobile bot commented Oct 13, 2021 •

edited

Loading

momo-ozawa commented Oct 14, 2021 •

edited

Loading

peril-wordpress-mobile bot commented Oct 14, 2021 •

edited

Loading

nikola-milicevic left a comment •

edited

Loading

leandroalonso left a comment •

edited

Loading