-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
My Site Dashboard: add AB test after site creation and option to change the default in Settings #18125
My Site Dashboard: add AB test after site creation and option to change the default in Settings #18125
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as described 🚀
One rookie question though: Why are we not using ExPlat (Abacus) for the AB experiment?
@hassaanelgarem Good question! From pbArwn-284-p2:
I haven't checked the status of A/B tests on ExPlat, but this is why we've been using the auth token. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as described! I validated the app_settings_initial_screen_changed
event on Tracks ✅
Part of #17873
Simulator.Screen.Recording.-.iPhone.13.-.2022-03-11.at.14.13.08.mp4
Additional info
The AB calculation is based on the token and it's the same used for the Empty Stats project.
To test
Do a clean install of the app and don't enable the My Site Dashboard feature flag. Then:
Enable the My Site Dashboard feature flag:
🔵 Tracked: app_settings_initial_screen_changed <selected: site_menu>
For the AB flow, there's no guarantee the Dashboard will be displayed for you. You can create a new account and site and test if it's displayed (or not).
If the
app_settings_initial_screen_changed
event is fired correctly, please validate it on Tracks.Regression Notes
Potential unintended areas of impact
n/a
What I did to test those areas of impact (or what existing automated tests I relied on)
n/a
What automated tests I added (or what prevented me from doing so)
n/a
PR submission checklist:
RELEASE-NOTES.txt
if necessary.