Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader Comments: Reuse the new comment content cell #17476

Closed
18 of 19 tasks
Tracked by #17475
dvdchr opened this issue Nov 15, 2021 · 0 comments
Closed
18 of 19 tasks
Tracked by #17475

Reader Comments: Reuse the new comment content cell #17476

dvdchr opened this issue Nov 15, 2021 · 0 comments

Comments

@dvdchr
Copy link
Contributor

dvdchr commented Nov 15, 2021

Refs #17475, pbArwn-2ks-p2#comment-4358, and pbArwn-38X-p2

Reuse the content cell from CommentDetailViewController, reuse logic where possible, and customize as needed. Here's a list of expected changes to the content cell:

Description Design
Author badge Screen Shot 2021-11-16 at 18 12 55
Highlighted comment1 Screen Shot 2021-11-16 at 18 14 32
Top-level only separators Screen Shot 2021-11-16 at 18 16 11
Pending comments Screen Shot 2021-11-16 at 18 15 09
Reply button active state Screen Shot 2021-11-16 at 18 17 37

Tasks

Display comments using the previous mechanism

Issues

  • The header cell sometimes goes missing after scrolling a lot of rows.

Postponed

  • Show pending comments from self. See: pbArwn-2ks-p2#comment-4417
  • Optimize table view performance. We'll revert to the previous rendering mechanism for now.

Footnotes

  1. pbArwn-2ks-p2#comment-3375 – when navigating to a specific comment in the thread, the comment should be highlighted for a second.

@dvdchr dvdchr self-assigned this Nov 15, 2021
@dvdchr dvdchr changed the title Reuse the new comment content cell. Reuse the new comment content cell Nov 15, 2021
@dvdchr dvdchr changed the title Reuse the new comment content cell Reader Comments: Reuse the new comment content cell Nov 15, 2021
@dvdchr dvdchr closed this as completed Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant