Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader Comments: Show ellipsis button when comment can be moderated #17557

Merged
merged 2 commits into from
Nov 25, 2021

Conversation

dvdchr
Copy link
Contributor

@dvdchr dvdchr commented Nov 24, 2021

Refs #17476
Depends on #17551

As titled, this shows the ellipsis icon instead of the share icon on the accessory button, when the user can moderate the site. Some notes:

  • This configuration is done outside the content cell, so site comments should not be affected.
  • Also, the allowsModeration method on the Comment is updated to account for comments fetched from the Reader endpoint.
  • Note that tapping on the ellipsis does nothing for now. It will be implemented later.

To Test

  • Enable the newCommentThread feature flag.
  • Make sure that you're logged in as a user that can moderate the site.
  • Go to My Site > Comments, select any reply comments, and tap on the comment header.
  • 🔍 Verify that the ellipsis accessory button is shown.
  • Go to Reader > Discover, and open any comment thread.
  • 🔍 Verify that the share button is shown.

Regression Notes

  1. Potential unintended areas of impact
    n/a. Feature is hidden behind a flag.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    n/a. Feature is hidden behind a flag.

  3. What automated tests I added (or what prevented me from doing so)
    n/a. Feature is hidden behind a flag.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

You can trigger an installable build for these changes by visiting CircleCI here.

@dvdchr dvdchr changed the base branch from develop to issue/17476-cell-indentation November 24, 2021 15:39
@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

Copy link
Contributor

@ScoutHarris ScoutHarris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 !

:shipit:

Base automatically changed from issue/17476-cell-indentation to develop November 25, 2021 05:48
@peril-wordpress-mobile
Copy link

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@dvdchr dvdchr merged commit ac6a682 into develop Nov 25, 2021
@dvdchr dvdchr deleted the issue/17476-overflow-menu-button branch November 25, 2021 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants