-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reader Comments: Show separator for last leaf comments #17549
Conversation
You can trigger an installable build for these changes by visiting CircleCI here. |
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
return | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Classic Xcode 13 formatting. 🙄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noted one UI issue. But since this is a WIP I'll go ahead and approve to not hold you up.
Thank you! This should be fixed in 31b7f3f. I noticed that this happened only after rotating from portrait to landscape. It doesn't happen when opening the comment thread while already in landscape orientation 😅. Here's a screenshot after rotating from portrait to landscape: I've also tested to ensure that this does not cause any issues in iPhone. 🙂 |
Refs #17476
This PR implements separator logic for the comment thread. Additionally, the separator is always hidden for the last row (as per the design).
I couldn't find a better term for this 😅 , but a "last leaf" comment is the last descendant of a top-level comment. I've also added a note in the code, but here's an example:
To Test
newCommentThread
feature flag.Regression Notes
Potential unintended areas of impact
n/a. Feature is hidden behind a flag.
What I did to test those areas of impact (or what existing automated tests I relied on)
n/a. Feature is hidden behind a flag.
What automated tests I added (or what prevented me from doing so)
n/a. Feature is hidden behind a flag.
PR submission checklist:
RELEASE-NOTES.txt
if necessary.