Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader Comments: Refactor content cell to have configurable render method #17634

Merged
merged 6 commits into from
Dec 8, 2021

Conversation

dvdchr
Copy link
Contributor

@dvdchr dvdchr commented Dec 7, 2021

Refs #17476

This PR refactors CommentContentTableViewCell so it could render its content in several different ways.

  • The web view in the cell is now replaced with an empty UIView. Depending on the rendering method, a WKWebView might be added to the UIView – or it could be a UITextView later on.
  • No new method has been added just yet, so this should still render the web view as before.
  • As this is a non-user facing change, please ensure that things look the same as before.

To test

Site Comments

  • Go to My Site > Comments.
  • Select any comment.
  • 🔍 Verify that the comment cell is displayed correctly and is not impacted by this change.

Comment Threads

  • Ensure that the newCommentThread is enabled.
  • Go to Reader > any comment threads.
  • 🔍 Verify that the comment threads are rendered with the web view method (same as before), and not impacted by this change.

Regression Notes

  1. Potential unintended areas of impact
    n/a. This feature is still hidden behind a flag.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    n/a. This feature is still hidden behind a flag.

  3. What automated tests I added (or what prevented me from doing so)
    n/a. This feature is still hidden behind a flag.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

Copy link
Contributor

@ScoutHarris ScoutHarris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@dvdchr dvdchr enabled auto-merge December 8, 2021 06:23
@dvdchr dvdchr merged commit c295466 into develop Dec 8, 2021
@dvdchr dvdchr deleted the issue/17476-rendering-mode branch December 8, 2021 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants