-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Reader IA] Update some minor UI style in Reader buttons and feed empty states #20059
[Reader IA] Update some minor UI style in Reader buttons and feed empty states #20059
Conversation
Generated by 🚫 dangerJS |
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, @thomashorta
I've checked both light and dark themes and it's working as expected. Code LGTM
The last commit I just sent just removes the unused resources that lint is complaining about, so I will merge as soon as the CI finishes building! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/reader-ia #20059 +/- ##
==================================================
Coverage 40.47% 40.47%
==================================================
Files 1447 1447
Lines 66779 66779
Branches 11028 11028
==================================================
Hits 27026 27026
Misses 37269 37269
Partials 2484 2484 ☔ View full report in Codecov by Sentry. |
Fixes #20028
Updates to
See video below to see the main changes.
20028-reader-ia-empty-feeds-and-interest-styles-shorter.mp4
Note: same as #19993 there are some pre-existing bugs (related to fetching fields after going to search/manage subscription screens). Those were not fixed here, as this PR is just touching the visual styles and some copies, but the GH issues are open in our backlog.
To Test:
I recommend using a secondary test account with no saved or liked posts, and unsubscribe from all blogs and tags, for making it easier to see the empty states.
Suggestion: also test in dark mode.
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.UI Changes Testing Checklist: