[Reader IA] Handle empty filter category states (0 Blogs / 0 Tags)

[thomashorta]

Fixes #19922

This PR updates the empty states in the bottom sheet for when the "Subscriptions" filters are empty (0 blogs or 0 tags). Bear in mind this PR does NOT update the styles of some screens (such as the empty feeds UI or the suggested tags UI) which still use old assets and colors. That style update will be made in a different PR.

WPcom cases

0 Blogs	0 Tags

Self-hosted cases

0 Blogs	0 Tags

---

To Test:

Empty blogs with WPcom account

1. Install and log into Jetpack with a WPcom account
2. Make sure to unfollow all blogs
3. Go to Reader -> Subscriptions
4. Tap the Blogs filter
5. Verify the empty state is shown
6. Tap the "Search for a blog" button
7. Verify it opens the search flow

Empty tags with WPcom account

1. Install and log into Jetpack with a WPcom account
2. Make sure to unfollow all tags
3. Go to Reader -> Subscriptions
4. Tap the Tags filter
5. Verify the empty state is shown
6. Tap the "Suggested tags" button
7. Verify the "Follow topics" screen opens
8. Go back
9. Tap the Tags filter
10. Tap "Subscribe to a tag" button
11. Verify the Tag management screen opens

Empty blogs/tags with self-hosted

1. Install and log into Jetpack with a self-hosted site (and no WPcom account)
2. Make sure to unfollow all blogs / tags
3. Go to Reader -> Subscriptions
4. Tap the Blogs / Tags filter
5. Verify the empty state is shown in both cases
6. Tap the "Search for a blog" button
7. Verify it opens the "Me"/login menu

---

Regression Notes

1. Potential unintended areas of impact

   • Broken connections in the buttons
   • Feed issues

2. What I did to test those areas of impact (or what existing automated tests I relied on)

   • Manual testing

3. What automated tests I added (or what prevented me from doing so)

   • Updated existing tests
   • Add new tests covering code additions

---

PR Submission Checklist:

• I have completed the Regression Notes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

---

UI Changes Testing Checklist:

• Portrait and landscape orientations.
• Light and dark modes.
• Fonts: Larger, smaller and bold text.
• High contrast.
• Talkback.
• Languages with large words or with letters/accents not frequently used in English.
• Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
• Large and small screen sizes. (Tablet and smaller phones)
• Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr19993-fbc8fd0
	Commit	fbc8fd0
	Direct Download	jetpack-prototype-build-pr19993-fbc8fd0.apk

Note: Google Login is not supported on these builds.

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr19993-fbc8fd0
	Commit	fbc8fd0
	Direct Download	wordpress-prototype-build-pr19993-fbc8fd0.apk

Note: Google Login is not supported on these builds.

[dangermattic]

	2 Warnings
⚠️	This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
⚠️	PR is not assigned to a milestone.

Generated by 🚫 Danger

[thomashorta]

Warning

I was not able to get to the roots of a few issues I found while testing the 0 blogs and 0 tags scenario and developing this PR. So I'm opening GitHub issues for a few things that I encountered, that were NOT introduced by this PR but seem to have been introduced during our Reader IA work, since I couldn't reproduce them in the production builds.

• [Reader IA][Bug][0 blogs/tags] Subscription feed tries refreshing when tapping filter pill #20009
• [Reader IA][Bug][0 tags/blogs] Infinite loading indicator on Subscription feed after subscribing to tags #20010
• [Reader IA][Bug] When following a blog through Search, the Subscription top bar filters should update #20011
• [Reader IA][Bug] Subscribing/Unsubscribing to a tag should auto-update tag filter pill in Subscriptions feed #20012

That said, I will not try to fix those other issues in this current PR, so bear in mind they exist while testing.

[peril-wordpress-mobile]

	Warnings
⚠️	PR is not assigned to a milestone.
⚠️	PR has more than 300 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

[daniloercoli]

Looks good to me, although I can replicate the issue already reported here:#19991

I think it's fine to proceed with merging this PR, and address the problem ^^ in a separate PR.

It's also better for @RenanLukas to give this a quick review.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0a34ab6) 40.43% compared to head (fbc8fd0) 40.44%.
Report is 33 commits behind head on feature/reader-ia.

Additional details and impacted files

@@                  Coverage Diff                  @@
##           feature/reader-ia   #19993      +/-   ##
=====================================================
+ Coverage              40.43%   40.44%   +0.01%     
=====================================================
  Files                   1445     1445              
  Lines                  66742    66755      +13     
  Branches               11028    11029       +1     
=====================================================
+ Hits                   26989    27002      +13     
  Misses                 37269    37269              
  Partials                2484     2484              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[RenanLukas]

Thanks for the PR, @thomashorta

I've faced a couple of issues (e.g. opening the tags bottom sheet with 0 tags triggers a new fetch) but they were not caused by this PR.

It's working as expected and code LGTM.