-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue/13268 implement clear and apply actions #13483
Issue/13268 implement clear and apply actions #13483
Conversation
…lear-and-apply-actions
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
You can test the changes on this Pull Request by downloading the APK here. |
@malinajirka - The clear functionality is not working for me, can you take a look - maybe I am doing something wrong? |
@zwarm Could you please double check that you are on the correct apk/branch. I just retested it on 2 emulators and it worked as expected. If it still doesn't work for you, what device/android are you testing it on? Thanks! |
I'm running: pr-13483-build-84851 on emulator Pixel 3a XL API 29. I re-downloaded the APK attached to this PR and tried again, no luck. @malinajirka It works on emulator Nexus 5X API 24. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created issue for the clear not working when tapping on checkboxes proper.
#13509
Feel free to merge after conflict is fixed.
👍
…ions # Conflicts: # WordPress/src/main/java/org/wordpress/android/ui/activitylog/list/filter/ActivityLogTypeFilterViewModel.kt
Thanks for the review ;)! |
Partially fixes #13268
This PR adds the clear and apply action to the Activity Log Type Filter screen.
Note: Review by commits might be easier.
Note2: Checked items are not persisted when you go back to activity log and re-open the activity type filter. That's coming in the next PR.
Merge instructions:
To test:
The rest of the functionality will be tested when the filter actually work - next week.
PR submission checklist:
RELEASE-NOTES.txt
if necessary.