Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/13268 implement clear and apply actions #13483

Merged
merged 10 commits into from
Dec 1, 2020

Conversation

malinajirka
Copy link
Contributor

@malinajirka malinajirka commented Nov 26, 2020

Partially fixes #13268

This PR adds the clear and apply action to the Activity Log Type Filter screen.

Note: Review by commits might be easier.
Note2: Checked items are not persisted when you go back to activity log and re-open the activity type filter. That's coming in the next PR.

Merge instructions:

  1. Make sure Issue/13268 on item click #13470 is reviewed
  2. Remove "Not ready for merge" label
  3. Merge this PR

To test:

  1. My site -> Activity Log
  2. Click on "Activity type" chip
  3. Try to select multiple items
  4. Click on the Clear action and notice all items get de-selected
  5. Click on the Apply action and notice the screen gets dismissed

The rest of the functionality will be tested when the filter actually work - next week.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Nov 26, 2020

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Nov 26, 2020

You can test the changes on this Pull Request by downloading the APK here.

Base automatically changed from issue/13268-on-item-click to develop December 1, 2020 05:09
@zwarm zwarm self-assigned this Dec 1, 2020
@zwarm
Copy link
Contributor

zwarm commented Dec 1, 2020

@malinajirka - The clear functionality is not working for me, can you take a look - maybe I am doing something wrong?
ezgif com-gif-maker (1)

@malinajirka
Copy link
Contributor Author

malinajirka commented Dec 1, 2020

@zwarm Could you please double check that you are on the correct apk/branch. I just retested it on 2 emulators and it worked as expected. If it still doesn't work for you, what device/android are you testing it on? Thanks!

@zwarm
Copy link
Contributor

zwarm commented Dec 1, 2020

I'm running: pr-13483-build-84851 on emulator Pixel 3a XL API 29. I re-downloaded the APK attached to this PR and tried again, no luck. @malinajirka

It works on emulator Nexus 5X API 24.
Doesn't work on emulator Pixel 4 XL API 30 either.

Copy link
Contributor

@zwarm zwarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created issue for the clear not working when tapping on checkboxes proper.
#13509

Feel free to merge after conflict is fixed.
👍

…ions

# Conflicts:
#	WordPress/src/main/java/org/wordpress/android/ui/activitylog/list/filter/ActivityLogTypeFilterViewModel.kt
@malinajirka
Copy link
Contributor Author

Thanks for the review ;)!

@malinajirka malinajirka merged commit 9f35e15 into develop Dec 1, 2020
@malinajirka malinajirka deleted the issue/13268-implement-clear-and-apply-actions branch December 1, 2020 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jetpack Section: Activity Log
2 participants