-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue/13268 persist activity type filters in parent vm #13485
Merged
zwarm
merged 7 commits into
develop
from
issue/13268-persist-activity-type-filters-in-parent-vm
Dec 1, 2020
Merged
Issue/13268 persist activity type filters in parent vm #13485
zwarm
merged 7 commits into
develop
from
issue/13268-persist-activity-type-filters-in-parent-vm
Dec 1, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
31 tasks
You can test the changes on this Pull Request by downloading the APK here. |
…ue/13268-persist-activity-type-filters-in-parent-vm
Base automatically changed from
issue/13268-implement-clear-and-apply-actions
to
develop
December 1, 2020 16:01
zwarm
approved these changes
Dec 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@malinajirka
All works as expected. The selection is persisted until you leave activityLog. 👍
zwarm
deleted the
issue/13268-persist-activity-type-filters-in-parent-vm
branch
December 1, 2020 16:09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #13268
Merge instructions:
This PR adds support for persisting checked items when the user sets a filter on Activity Type filter screen and opens it again from Activity log. The items are intentionally not persisted when the user leaves the Activity Log feature completely.
To test:
Test anything else you can think of (configuration change), clear action, leaving the screen, etc..
PR submission checklist:
RELEASE-NOTES.txt
if necessary.