Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/13268 persist activity type filters in parent vm #13485

Merged

Conversation

malinajirka
Copy link
Contributor

@malinajirka malinajirka commented Nov 27, 2020

Partially fixes #13268

Merge instructions:

  1. Make sure Issue/13268 implement clear and apply actions #13483 is merged
  2. Remove not ready for merge label
  3. Merge this PR

This PR adds support for persisting checked items when the user sets a filter on Activity Type filter screen and opens it again from Activity log. The items are intentionally not persisted when the user leaves the Activity Log feature completely.

To test:

  1. Open My Site
  2. Open Activity Log
  3. Click on "Activity Type" chip
  4. Select some items
  5. Click on "x" in the top left corner
  6. Click on "Activity Type" chip again
  7. Notice none of the items is checked
  8. Select some items
  9. Click on Apply
  10. Click on "Activity Type" chip again
  11. Notice previously selected items are checked
  12. Click on apply
  13. Leave the Activity Log
  14. Open Activity Log
  15. Click on "Activity Type" chip again
  16. Notice none of the items is checked

Test anything else you can think of (configuration change), clear action, leaving the screen, etc..

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Nov 27, 2020

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@malinajirka malinajirka mentioned this pull request Nov 27, 2020
31 tasks
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Nov 27, 2020

You can test the changes on this Pull Request by downloading the APK here.

@zwarm zwarm self-assigned this Dec 1, 2020
…ue/13268-persist-activity-type-filters-in-parent-vm
Base automatically changed from issue/13268-implement-clear-and-apply-actions to develop December 1, 2020 16:01
Copy link
Contributor

@zwarm zwarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malinajirka
All works as expected. The selection is persisted until you leave activityLog. 👍

@zwarm zwarm merged commit 6291c3a into develop Dec 1, 2020
@zwarm zwarm deleted the issue/13268-persist-activity-type-filters-in-parent-vm branch December 1, 2020 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jetpack Section: Activity Log
2 participants