Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue/13268 on item click #13470

Merged
merged 9 commits into from
Dec 1, 2020
Merged

Issue/13268 on item click #13470

merged 9 commits into from
Dec 1, 2020

Conversation

malinajirka
Copy link
Contributor

@malinajirka malinajirka commented Nov 24, 2020 •
edited
Loading

Partially fixes #13268

This PR adds onItemClick listener to items on the Activity Type Filter screen. The DiffUtil is added so the item selector's animation doesn't get interrupted.

Merge instructions:

  1. Make sure Issue/13268 bind ui #13469 is merged
  2. Remove "Not ready for merge" label
  3. Merge this PR

To test:

  • Make sure the ActivityLogFiltersFeatureConfig is enabled
  1. My site -> Activity Log
  2. Click on "Activity Type" chip
  3. Click on an unchecked row and notice it gets checked
  4. Click on a checked row again and notice it gets unchecked

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@malinajirka malinajirka added this to the 16.3 milestone Nov 24, 2020
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Nov 24, 2020 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Nov 24, 2020 •
edited
Loading

You can test the changes on this Pull Request by downloading the APK here.

@ParaskP7 ParaskP7 removed their request for review November 25, 2020 08:35
@malinajirka malinajirka modified the milestones: 16.3, 16.4 Nov 26, 2020
Base automatically changed from issue/13268-bind-ui to develop November 26, 2020 13:03
This was referenced Nov 26, 2020
Merged
Closed
ashiagr
ashiagr approved these changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@ashiagr ashiagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described 👍.
Just left 2 nitpicks. Feel free to merge after considering them.

...main/java/org/wordpress/android/ui/activitylog/list/filter/ActivityLogTypeFilterViewModel.kt Outdated Show resolved Hide resolved
.../java/org/wordpress/android/ui/activitylog/list/filter/ActivityLogTypeFilterViewModelTest.kt Outdated Show resolved Hide resolved
.idea/compiler.xml Outdated Show resolved Hide resolved
@ashiagr ashiagr removed the request for review from zwarm November 30, 2020 06:09
@malinajirka
Copy link
Contributor Author

Thanks for the review @ashiagr. I've fixed the issues.

@ashiagr
Copy link
Contributor

ashiagr commented Dec 1, 2020

LGTM 👍.

@ashiagr ashiagr merged commit b9c9634 into develop Dec 1, 2020
@ashiagr ashiagr deleted the issue/13268-on-item-click branch December 1, 2020 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashiagr ashiagr ashiagr approved these changes

Assignees
No one assigned
Labels
Activity Log Jetpack
Projects
None yet
Milestone
16.4
Development

Successfully merging this pull request may close these issues.

Jetpack Section: Activity Log
2 participants
@malinajirka @ashiagr