Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Gutenberg so show content structure information. #12186

Merged
merged 12 commits into from
Jun 17, 2020
Merged

Update Gutenberg so show content structure information. #12186

merged 12 commits into from
Jun 17, 2020

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Jun 12, 2020 •
edited
Loading

Fixes wordpress-mobile/gutenberg-mobile#506

GB-Mobile PR: wordpress-mobile/gutenberg-mobile#2380

This PR just updates the GB reference to have the new bridge method that sends the content metrics data.

Shows the content structure information of the post:

To test:

  • Start the app
  • Create a post
  • Write some content
  • Tap on the top right ... button
  • Check if the content structure option is available
  • Tap on the option
  • Check if a dialog presents the information.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@SergioEstevao SergioEstevao added Gutenberg Editing and display of Gutenberg blocks. gutenberg-mobile labels Jun 12, 2020
@SergioEstevao SergioEstevao added this to the 15.1 milestone Jun 12, 2020
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 12, 2020 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@SergioEstevao SergioEstevao mentioned this pull request Jun 12, 2020
Merged
2 tasks
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 12, 2020 •
edited
Loading

You can test the changes on this Pull Request by downloading the APK here.

@hypest hypest mentioned this pull request Jun 13, 2020
Merged
3 tasks
@oguzkocer
Copy link
Contributor

Hi there! 15.1 is being frozen, so this PR is being bumped to 15.2. If these changes have to be shipped with 15.1, please target release/15.1 and cc me in the PR so I can cut a new beta release. Also if you can keep the release dates in mind and bump the PRs & issues you are working on before the code freeze date, we'd really appreciate it.

This is a standard release version bump message. Let me know if you have any feedback.

@oguzkocer oguzkocer modified the milestones: 15.1, 15.2 Jun 15, 2020
@SergioEstevao
Update content structure strings.
9f61e84 
Make the strings used uniform with iOS and web.
@SergioEstevao
Merge pull request #12191 from wordpress-mobile/gutenberg/display_con…
fda4314 
…tent_metrics-hypest

Display content information metrics
@SergioEstevao
Update GB reference.
9a43991
mchowning
mchowning suggested changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good and generally works well. There's just one change I think we need.

...itor/WordPressEditor/src/main/java/org/wordpress/android/editor/GutenbergEditorFragment.java Outdated Show resolved Hide resolved
mchowning
mchowning approved these changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and it's working well! :shipit:

@SergioEstevao SergioEstevao mentioned this pull request Jun 16, 2020
Merged
2 tasks
@SergioEstevao SergioEstevao changed the title Update Gutenberg bridge to support content info. Update Gutenberg so show content structure information. Jun 17, 2020
@SergioEstevao SergioEstevao merged commit d2ad94c into develop Jun 17, 2020
@SergioEstevao SergioEstevao deleted the gutenberg/display_content_metrics branch June 17, 2020 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchowning mchowning mchowning approved these changes

@hypest hypest Awaiting requested review from hypest

Assignees
No one assigned
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Milestone
15.2
Development

Successfully merging this pull request may close these issues.

Display word, character count on overflow menu Action Sheet
4 participants
@SergioEstevao @oguzkocer @hypest @mchowning